Page MenuHomeFreeBSD
Differential D15921

Attach dev.cpu nodes on SMT cores, using only the first found thread
ClosedPublic
Actions

Authored by jhibbits on Jun 20 2018, 4:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 23, 7:00 AM
Unknown Object (File)
Mon, Sep 21, 4:22 PM
Unknown Object (File)
Mon, Sep 21, 4:14 PM
Unknown Object (File)
Mon, Sep 21, 2:43 PM
Unknown Object (File)
Sun, Sep 6, 8:17 PM
Unknown Object (File)
Sun, Sep 6, 7:25 PM
Unknown Object (File)
Sun, Sep 6, 4:10 PM
Unknown Object (File)
Sun, Sep 6, 4:06 PM
View All Files
Subscribers
imp

Details

Reviewers
nwhitehorn
Commits
rS335442: Attach dev.cpu nodes on powerpc SMT cores, using only the first found thread
Summary

In order to use cpufreq(4), a dev.cpu attachment must be created. If the IBM property is found denoting SMT, attach only to the first thread setup, so that a cpufreq device can bind.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17473
Build 17303: arc lint + arc unit

Event Timeline

jhibbits created this revision.Jun 20 2018, 4:53 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2018, 4:53 AM
Harbormaster completed remote builds in B17473: Diff 44127.Jun 20 2018, 4:53 AM
nwhitehorn accepted this revision.Jun 20 2018, 4:59 AM

Approved if you fix the #if 0 bit.

sys/dev/ofw/ofw_cpu.c
199

Probably this part can just be deleted?

This revision is now accepted and ready to land.Jun 20 2018, 4:59 AM
jhibbits added inline comments.Jun 20 2018, 1:23 PM
sys/dev/ofw/ofw_cpu.c
199

Yes it can. I had kept it in just for reference, and forgot to delete it.

Closed by commit rS335442: Attach dev.cpu nodes on powerpc SMT cores, using only the first found thread (authored by jhibbits). · Explain WhyJun 20 2018, 1:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
ofw/
39 lines

Diff 44127

View Options

sys/dev/ofw/ofw_cpu.c

Loading...