top(1): Fix Coverity warning
ClosedPublic
Actions

Authored by asomers on Jun 19 2018, 5:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jul 17, 5:44 AM

	Unknown Object (File)
	Fri, Jul 10, 11:45 PM

	Unknown Object (File)
	Thu, Jul 9, 5:31 AM

	Unknown Object (File)
	Jun 9 2026, 7:50 PM

	Unknown Object (File)
	May 16 2026, 11:03 PM

	Unknown Object (File)
	May 10 2026, 2:11 PM

	Unknown Object (File)
	May 10 2026, 2:07 PM

	Unknown Object (File)
	May 8 2026, 4:46 AM

View All Files

Subscribers

imp

Details

Reviewers

eadler

Commits

rS335381: top(1): Fix Coverity warning

Summary

top(1): Fix Coverity warning

Don't call strerror on negative errnos

Reported by: Coverity
CID: 976708

Test Plan

Use top's interactive kill and renice commands with invalid arguments and
verify that the correct error is printed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jun 19 2018, 5:52 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2018, 5:52 PM

Harbormaster completed remote builds in B17450: Diff 44087.Jun 19 2018, 5:52 PM

eadler accepted this revision.Jun 19 2018, 6:24 PM

This revision is now accepted and ready to land.Jun 19 2018, 6:24 PM

Closed by commit rS335381: top(1): Fix Coverity warning (authored by asomers). · Explain WhyJun 19 2018, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

top/

commands.c

2 lines

Diff 44091

View Options

head/usr.bin/top/commands.c

top(1): Fix Coverity warningClosedPublicActions