Page MenuHomeFreeBSD
Differential D14804

fix part of Uses section in Porter's Handbook
ClosedPublic
Actions

Authored by linimon on Mar 23 2018, 8:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 2, 10:03 PM
Unknown Object (File)
Wed, Sep 30, 3:45 PM
Unknown Object (File)
Sun, Sep 27, 4:41 AM
Unknown Object (File)
Sun, Sep 27, 4:14 AM
Unknown Object (File)
Sun, Sep 27, 3:24 AM
Unknown Object (File)
Sun, Sep 27, 2:20 AM
Unknown Object (File)
Sun, Sep 27, 12:47 AM
Unknown Object (File)
Wed, Sep 9, 2:58 PM
View All Files
Subscribers
None

Details

Reviewers
wblock
mat
Group Reviewers
portmgr
Commits
rD51775: The text describing compiler.mk was unclear.
Summary

The text describing compiler.mk is too hard to read.

In addition, it misses describing c++11-lang, and 'env' (the default). For these, copy the descriptions from Mk/Uses/compiler.mk.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

linimon created this revision.Mar 23 2018, 8:05 AM
Herald added a reviewer: mat. · View Herald TranscriptMar 23 2018, 8:05 AM
mat added a comment.Jun 3 2018, 6:35 PM

I would rather all the USES have the same way to display their arguments, so I would rather you keep the way it was written before, or change all of them :-)

linimon updated this revision to Diff 43291.Jun 3 2018, 8:29 PM

Incorporate feedback.

mat added inline comments.Jun 4 2018, 10:48 AM
books/porters-handbook/uses/chapter.xml
281–282

Please, add a space after the :. I think it is important to keep the (none), even if it means env, because there can be no arguments.

linimon updated this revision to Diff 43304.Jun 4 2018, 12:01 PM

Updated per request

mat accepted this revision.Jun 4 2018, 12:13 PM
This revision is now accepted and ready to land.Jun 4 2018, 12:13 PM
Closed by commit rD51775: The text describing compiler.mk was unclear. (authored by linimon). · Explain WhyJun 4 2018, 10:43 PM
This revision was automatically updated to reflect the committed changes.
linimon mentioned this in rD51775: The text describing compiler.mk was unclear..

Revision Contents
Changeset List

PathSize
books/
porters-handbook/
uses/
13 lines

Diff 43304

View Options

books/porters-handbook/uses/chapter.xml

Loading...