Adding new port x11/brisk-menu v0.5.1
ClosedPublic
Actions

Authored by ericbsd on Jun 1 2018, 1:36 AM.

Details

Reviewers

bapt
wg

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ericbsd created this revision.Jun 1 2018, 1:36 AM

Herald added a subscriber: mat. · View Herald TranscriptJun 1 2018, 1:36 AM

Harbormaster completed remote builds in B16955: Diff 43222.Jun 1 2018, 1:36 AM

fbsd:nokeywords null yes \ No newline at end of property
svn:eol-style null native \ No newline at end of property
svn:mime-type null text/plain \ No newline at end of property

what is that?

bapt requested changes to this revision.Jun 1 2018, 7:34 AM

bapt added inline comments.

x11/brisk-menu/Makefile
26	I do not see USES=mate gnome which you should have

This revision now requires changes to proceed.Jun 1 2018, 7:34 AM

mat added inline comments.Jun 1 2018, 10:17 AM

x11/brisk-menu/Makefile
26	Mmmm, actually, if you look around lines 1415-1420 of Mk/bsd.port.mk, you'll see that it is added by the framework, which may be wrong and should probably generate a warning if mate/gnome is not already in USES.

ericbsd updated this revision to Diff 43228.Jun 1 2018, 11:12 AM

ericbsd marked 2 inline comments as done.

bapt accepted this revision.Jun 1 2018, 11:15 AM

bapt added inline comments.

x11/brisk-menu/Makefile
26	exactly, those lines are there for backward compat

This revision is now accepted and ready to land.Jun 1 2018, 11:15 AM

mat added inline comments.Jun 1 2018, 11:39 AM

x11/brisk-menu/Makefile
26	Then they should generate a dev warning.

In D15639#330380, @ericbsd wrote:

fbsd:nokeywords null yes \ No newline at end of property
svn:eol-style null native \ No newline at end of property
svn:mime-type null text/plain \ No newline at end of property

what is that?

Those are subversion properties that are automatically added:

$ svn propget svn:auto-props svn+ssh://repo.freebsd.org/ports
bsd.*.mk     = svn:keywords=FreeBSD=%H
distinfo*    = fbsd:nokeywords=yes
extrapatch-* = fbsd:nokeywords=yes
extra-patch-*= fbsd:nokeywords=yes
patch-*      = fbsd:nokeywords=yes
pkg-*        = fbsd:nokeywords=yes
Makefile*    = svn:keywords=FreeBSD=%H
*            = svn:eol-style=native; svn:mime-type=text/plain

In D15639#330450, @mat wrote:
In D15639#330380, @ericbsd wrote:

fbsd:nokeywords null yes \ No newline at end of property
svn:eol-style null native \ No newline at end of property
svn:mime-type null text/plain \ No newline at end of property

what is that?

Those are subversion properties that are automatically added:
$ svn propget svn:auto-props svn+ssh://repo.freebsd.org/ports
bsd.*.mk     = svn:keywords=FreeBSD=%H
distinfo*    = fbsd:nokeywords=yes
extrapatch-* = fbsd:nokeywords=yes
extra-patch-*= fbsd:nokeywords=yes
patch-*      = fbsd:nokeywords=yes
pkg-*        = fbsd:nokeywords=yes
Makefile*    = svn:keywords=FreeBSD=%H
*            = svn:eol-style=native; svn:mime-type=text/plain