Exit with an error if a linker hints file can't be found.
ClosedPublic
Actions

Authored by jhb on May 25 2018, 9:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 20, 1:31 AM

	Unknown Object (File)
	Mon, May 18, 12:48 AM

	Unknown Object (File)
	Mon, May 18, 12:48 AM

	Unknown Object (File)
	Mon, May 18, 12:32 AM

	Unknown Object (File)
	Sun, May 17, 3:00 AM

	Unknown Object (File)
	Thu, May 7, 10:51 AM

	Unknown Object (File)
	Thu, May 7, 4:27 AM

	Unknown Object (File)
	Wed, May 6, 11:22 AM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rS335181: Exit with an error if a linker hints file can't be found.

Summary

Continuing with a NULL hints variable just triggers a segfault later on.
The other error cases in this function all exit for an error rather than
warning.

Test Plan

boot a mips image under qemu. devmatch core dumped previously, not it just exits after the error message

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16852
Build 16731: arc lint + arc unit

Event Timeline

jhb created this revision.May 25 2018, 9:53 PM

Harbormaster completed remote builds in B16852: Diff 43020.May 25 2018, 9:53 PM

Ping

imp accepted this revision.Jun 13 2018, 7:09 PM

This revision is now accepted and ready to land.Jun 13 2018, 7:09 PM

Closed by commit rS335181: Exit with an error if a linker hints file can't be found. (authored by jhb). · Explain WhyJun 14 2018, 10:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sbin/

devmatch/

devmatch.c

8 lines

Diff 43020

View Options

Exit with an error if a linker hints file can't be found.ClosedPublicActions