Differential D15417

devel/youcompleteme: Enable Python 3 support
ClosedPublic
Actions

Authored by ultima on May 13 2018, 5:27 PM.

Details

Reviewers

None

Group Reviewers

Python

Commits

rP472401: * Add python flavors support. This will allow

Summary

devel/youcompleteme: Enable Python 3 support

This software supports, Python 2.7 and 3.4+, enable
Python 3 support accordingly

Reviewed_by: koobs
Differential_Revision: D15417

Test Plan

portlint:
testport:
maketest:

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 16569
Build 16483: arc lint + arc unit

Event Timeline

ultima created this revision.May 13 2018, 5:27 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 13 2018, 5:27 PM

Harbormaster completed remote builds in B16564: Diff 42486.May 13 2018, 5:27 PM

ultima added a reviewer: Python.May 13 2018, 5:28 PM

antoine added a subscriber: antoine.May 13 2018, 6:35 PM

antoine added inline comments.

devel/youcompleteme/Makefile
7–8	I believe it's missing a PKGNAMEPREFIX/SUFFIX to distinguish the flavored packages

Add PKGNAMEPREFIX

Harbormaster completed remote builds in B16569: Diff 42491.May 13 2018, 6:53 PM

ultima marked an inline comment as done.May 13 2018, 6:54 PM

ultima added inline comments.

devel/youcompleteme/Makefile
7–8	Yup, that was it. Thanks! =]

ultima marked an inline comment as done.May 13 2018, 6:54 PM

koobs retitled this revision from devel/youcompleteme: Add Python 3 support to devel/youcompleteme: Enable Python 3 support.May 14 2018, 2:05 AM

koobs edited the summary of this revision. (Show Details)

koobs edited the test plan for this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2018, 9:51 PM

Closed by commit rP472401: * Add python flavors support. This will allow (authored by ultima). · Explain Why

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Jun 14 2018, 10:10 PM

head/devel/youcompleteme/Makefile
19–27 ↗	(On Diff #43787)	What? Please put back PY_FLAVOR.

mat added inline comments.Jun 14 2018, 10:12 PM

head/devel/youcompleteme/Makefile
68–70 ↗	(On Diff #43787)	You could have easily avoided the bsd.port.pre.mk inclusion by doing: CMAKE_ARGS_PY3= -DUSE_PYTHON2:BOOL=OFF CMAKE_ARGS= ${CMAKE_ARGS_PY${PYTHON_MAJOR_VER}}

Revision Contents
Changeset List

Path

Size

devel/

youcompleteme/

Makefile

30 lines

Diff 42491

View Options

devel/youcompleteme/Makefile

devel/youcompleteme: Enable Python 3 supportClosedPublicActions