Page MenuHomeFreeBSD
Differential D2022

Add a DS1307 i2c real-time clock driver
ClosedPublic
Actions

Authored by loos on Mar 7 2015, 2:39 PM.
Tags
None
Referenced Files
F108262605: D2022.id.diff
Thu, Jan 23, 5:32 AM
F108260887: D2022.diff
Thu, Jan 23, 5:03 AM
Unknown Object (File)
Wed, Jan 8, 7:27 PM
Unknown Object (File)
Oct 23 2024, 1:43 PM
Unknown Object (File)
Oct 23 2024, 1:19 PM
Unknown Object (File)
Sep 24 2024, 9:50 AM
Unknown Object (File)
Sep 17 2024, 11:33 AM
Unknown Object (File)
Sep 9 2024, 9:45 AM
View All 99 Files
Subscribers
imp

Details

Reviewers
rpaulo
• ian
Group Reviewers
manpages
Commits
rS280300: Add a driver for the Dallas/Maxim DS1307, another common i2c RTC.
Summary

Add a i2c driver for the Maxim DS1307 real-time clock.

The SQW/OUT pin control is made with sysctl(8) knobs.

Tested on: RPi

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

loos updated this revision to Diff 4134.Mar 7 2015, 2:39 PM
loos retitled this revision from to Add a DS1307 i2c real-time clock driver.
loos updated this object.
loos edited the test plan for this revision. (Show Details)
loos added reviewers: manpages, rpaulo, • ian.
Herald added a subscriber: imp. · View Herald TranscriptMar 7 2015, 2:39 PM
rpaulo added inline comments.Mar 8 2015, 11:26 PM
sys/dev/iicbus/ds1307.c
206–208

There's an off by one here. You need to use ntimes() - 1;

loos updated this revision to Diff 4184.Mar 11 2015, 5:35 PM

Fix the off by one bug.

loos added inline comments.Mar 11 2015, 5:37 PM
sys/dev/iicbus/ds1307.c
206–208

Indeed. Fixed on new version.

rpaulo accepted this revision.Mar 11 2015, 10:55 PM
rpaulo edited edge metadata.

Thanks for fixing your other drivers!

This revision is now accepted and ready to land.Mar 11 2015, 10:55 PM
loos closed this revision.Mar 20 2015, 7:51 PM
loos updated this revision to Diff 4308.

Closed by commit rS280300 (authored by @loos).

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line
131 lines
sys/
conf/
1 line
dev/
iicbus/
411 lines
59 lines

Diff 4184

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/ds1307.4

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/dev/iicbus/ds1307.c

Loading...
View Options

sys/dev/iicbus/ds1307reg.h

Loading...