Page MenuHomeFreeBSD
Differential D2011

Categorize certain kernel builds as being broken in certain places.
ClosedPublic
Actions

Authored by imp on Mar 5 2015, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 11:34 PM
Unknown Object (File)
Feb 17 2025, 7:05 AM
Unknown Object (File)
Feb 17 2025, 6:16 AM
Unknown Object (File)
Feb 8 2025, 4:29 PM
Unknown Object (File)
Jan 31 2025, 3:22 PM
Unknown Object (File)
Jan 23 2025, 5:33 AM
Unknown Object (File)
Jan 23 2025, 5:02 AM
Unknown Object (File)
Jan 12 2025, 7:57 AM
View All Files
Subscribers
emaste

Details

Reviewers
nwhitehorn
simon
Commits
rS280728: Categorize certain kernel builds as being broken in certain places.
rS280727: Add support for specifying unsupported / broken options that override

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

imp updated this revision to Diff 4116.Mar 5 2015, 4:25 PM
imp retitled this revision from to Categorize certain kernel builds as being broken in certain places..
imp updated this object.
imp edited the test plan for this revision. (Show Details)
imp added reviewers: nwhitehorn, simon.Mar 5 2015, 4:27 PM
nwhitehorn added inline comments.Mar 5 2015, 4:31 PM
sys/conf/kern.opts.mk
67

Why not just test for MACHINE_ARCH == powerpc? Just to be explicit so no one "fixes" it to be "MACHINE_CPUARCH"?

imp added inline comments.Mar 5 2015, 5:52 PM
sys/conf/kern.opts.mk
67

Good idea! I had some other stuff here and wound up collapsing the .if's when EISA moved down.

emaste added a subscriber: emaste.Mar 6 2015, 2:05 PM
imp closed this revision.Mar 27 2015, 2:51 AM
imp updated this revision to Diff 4450.

Closed by commit rS280727 (authored by @imp).

Revision Contents
Changeset List

PathSize
sys/
conf/
28 lines

Diff 4116

View Options

sys/conf/kern.opts.mk

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
int env_verbosity; int env_verbosity;
static void usage(void); static void usage(void);
int int
main(int argc, char **argv) main(int argc, char **argv)
{ {
char *altpath, **ep, *p, **parg; char *altpath, **ep, *p, **parg, term;
char *cleanenv[1]; char *cleanenv[1];
int ch, want_clear; int ch, want_clear;
int rtrn; int rtrn;
altpath = NULL; altpath = NULL;
want_clear = 0; want_clear = 0;
while ((ch = getopt(argc, argv, "-iP:S:u:v")) != -1) term = '\n';
while ((ch = getopt(argc, argv, "-0iP:S:u:v")) != -1)
switch(ch) { switch(ch) {
case '-': case '-':
case 'i': case 'i':
want_clear = 1; want_clear = 1;
break; break;
case '0':
term = '\0';
break;
case 'P': case 'P':
altpath = strdup(optarg); altpath = strdup(optarg);
break; break;
case 'S': case 'S':
/* /*
* The -S option, for "split string on spaces, with * The -S option, for "split string on spaces, with
* support for some simple substitutions"... * support for some simple substitutions"...
*/ */
Show All 27 Lines if (env_verbosity)
fprintf(stderr, "#env setenv:\t%s\n", *argv); fprintf(stderr, "#env setenv:\t%s\n", *argv);
*p = '\0'; *p = '\0';
rtrn = setenv(*argv, p + 1, 1); rtrn = setenv(*argv, p + 1, 1);
*p = '='; *p = '=';
if (rtrn == -1) if (rtrn == -1)
err(EXIT_FAILURE, "setenv %s", *argv); err(EXIT_FAILURE, "setenv %s", *argv);
} }
if (*argv) { if (*argv) {
if (term == '\0')
errx(125, "cannot specify command with -0");
swillsUnsubmitted
Not Done
Inline Actions

I think maybe this should call exit(), perhaps with a non-zero exit, perhaps with 125 instead.

swills: I think maybe this should call `exit()`, perhaps with a non-zero exit, perhaps with 125 instead.
impUnsubmitted
Not Done
Inline Actions

what's a 125?

imp: what's a 125?
else {
if (altpath) if (altpath)
search_paths(altpath, argv); search_paths(altpath, argv);
if (env_verbosity) { if (env_verbosity) {
fprintf(stderr, "#env executing:\t%s\n", *argv); fprintf(stderr, "#env executing:\t%s\n", *argv);
for (parg = argv, argc = 0; *parg; parg++, argc++) for (parg = argv, argc = 0; *parg; parg++, argc++)
fprintf(stderr, "#env arg[%d]=\t'%s'\n", fprintf(stderr, "#env arg[%d]=\t'%s'\n",
argc, *parg); argc, *parg);
if (env_verbosity > 1) if (env_verbosity > 1)
sleep(1); sleep(1);
} }
execvp(*argv, argv); execvp(*argv, argv);
err(errno == ENOENT ? 127 : 126, "%s", *argv); err(errno == ENOENT ? 127 : 126, "%s", *argv);
} }
}
for (ep = environ; *ep; ep++) for (ep = environ; *ep; ep++)
(void)printf("%s\n", *ep); (void)printf("%s%c", *ep, term);
exit(0); exit(0);
} }
static void static void
usage(void) usage(void)
{ {
(void)fprintf(stderr, (void)fprintf(stderr,
"usage: env [-iv] [-P utilpath] [-S string] [-u name]\n" "usage: env [-0iv] [-P utilpath] [-S string] [-u name]\n"
" [name=value ...] [utility [argument ...]]\n"); " [name=value ...] [utility [argument ...]]\n");
exit(1); exit(1);
} }