Some ports do not honour $LD or -fuse-ld=bfd in $CFLAGS, but do invoke ld via $PATH. Automatically set BINARY_ALIAS+=ld=ld.bfd when LLD_UNSAFE is active to use ld.bfd for these ports.
Details
Details
- Reviewers
antoine - Group Reviewers
portmgr O5: Ports Framework (Owns No Changed Paths) - Commits
- rP465900: Use BINARY_ALIAS to make LLD_UNSAFE more widely applicable
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
These ports currently have BINARY_ALIAS=ld=ld.bfd and should be able to use just LLD_UNSAFE with this change:
devel/pdcurses
devel/libds
lang/myrddin
irc/evangeline
sysutils/installwatch
I tested the first two and they built successfully.
Comment Actions
Mmmm, should not this be in the .if exists(/usr/bin/ld.bfd) block? Or does USE_BINUTILS also installs a ld.bfd and a ld.ldd?
I think this was already added to some ports, I am not sure how the BINARY_ALIAS code will work if there is the same alias twice, so make sure you remove the existing aliases at the same time.
Comment Actions
I am not sure if using BINARY_ALIAS+= ld=ld.bfd is correct.
If both /usr/bin/ld.bfd and binutils from ports are installed, it will alias to which ld.bfd which is /usr/bin/ld.bfd and not to /usr/local/bin/ld.bfd
Maybe it should be BINARY_ALIAS+= ld=${LD} instead?
Comment Actions
Yes, USE_BINUTILS also installs ld.bfd.
I think this was already added to some ports, I am not sure how the BINARY_ALIAS code will work if there is the same alias twice, so make sure you remove the existing aliases at the same time.
Good point, will do.
| Mk/bsd.port.mk | ||
|---|---|---|
| 1848 | += ? | |