python36: libressl 2.7 compatibility
ClosedPublic
Actions

Authored by vishwin on Mar 24 2018, 9:13 PM.

Details

Reviewers

brnrd
koobs
sunpoet

Group Reviewers

Python

Commits

rP470858: MFH: r468566 r469635
rP468569: lang/python36: Fix build with LibreSSL 2.7
rP468567: lang/python35: Fix build with LibreSSL 2.7
rP468566: lang/python27: Fix build with LibreSSL 2.7

Summary

See PR 226883. Upon libressl releasing 2.7.1, upstream released their patches.

Test Plan

testport succeeds with ssl=base and ssl=libressl-devel. Fails otherwise, at least on my machine.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 15787
Build 15798: arc lint + arc unit

Event Timeline

vishwin created this revision.Mar 24 2018, 9:13 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 24 2018, 9:13 PM

Harbormaster completed remote builds in B15787: Diff 40709.Mar 24 2018, 9:13 PM

No patch for 3.4?

3.4 isn't affected by this last time I tested. In fact, upstream only patched 2.7, 3.6, 3.7beta and master; I manually backported the 3.6 patch to 3.5.

Also, my build failures seem to come from using ccache a wee bit much. These patches actually all work.

Should PORTREVISION be bumped for these?

Bumping PORTREVISION is required when the port needs to be rebuilt because whatever was built has been updated. In this case, nothing builds, as far as I understand, so no.

Works fine for me for weeks now

This revision is now accepted and ready to land.Apr 23 2018, 6:56 PM

LGTM/Approved if this passes QA on all versions/archs (10,11,i386,amd64 explicitly, at least) eluded to in Issue 226883 Comment 3 and for all values of USES=ssl

Approved by: python (koobs)

Python	SSL provider	11.1 amd64	11.1 i386	10.4 amd64	10.4 i386
Python 2.7.14_1	1.0.2k/1.0.1u (base)	log	log	log	log
Python 2.7.14_1	LibreSSL 2.6.4_1	log	log	log	log
Python 2.7.14_1	LibreSSL 2.7.2	log	log	log	log
Python 2.7.14_1	OpenSSL 1.0.2o_2,1	log	log	log	log
Python 2.7.14_1	OpenSSL 1.1.0h_1	log	log	log	log
Python 2.7.14_1	OpenSSL 1.1.1p5	log	log	log	log
Python 3.5.5	1.0.2k/1.0.1u (base)	log	log	log	log
Python 3.5.5	LibreSSL 2.6.4_1	log	log	log	log
Python 3.5.5	LibreSSL 2.7.2	log	log	log	log
Python 3.5.5	OpenSSL 1.0.2o_2,1	log	log	log	log
Python 3.5.5	OpenSSL 1.1.0h_1	log	log	log	log
Python 3.6.5	1.0.2k/1.0.1u (base)	log	log	log	log
Python 3.6.5	LibreSSL 2.6.4_1	log	log	log	log
Python 3.6.5	LibreSSL 2.7.2	log	log	log	log
Python 3.6.5	OpenSSL 1.0.2o_2,1	log	log	log	log
Python 3.6.5	OpenSSL 1.1.0h_1	log	log	log	log
Python 3.6.5	OpenSSL 1.1.1p5	log	log	log	log