Page MenuHomeFreeBSD
Differential D14812

Correctly mark last section header in El Torito catalog
ClosedPublic
Actions

Authored by benno on Mar 23 2018, 9:31 PM.
Tags
None
Referenced Files
F137080214: D14812.id.diff
Fri, Nov 21, 2:45 AM
F137043548: D14812.id40658.diff
Fri, Nov 21, 1:08 AM
F137042272: D14812.id.diff
Fri, Nov 21, 1:05 AM
F137042118: D14812.id40655.diff
Fri, Nov 21, 1:04 AM
F137040776: D14812.diff
Fri, Nov 21, 1:01 AM
Unknown Object (File)
Wed, Nov 19, 8:38 PM
Unknown Object (File)
Fri, Nov 7, 9:21 PM
Unknown Object (File)
Sat, Nov 1, 3:24 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
imp
Commits
rS331467: Correctly mark the last El Torito section header.
Summary

The final section header in the El Torito catalog should be marked as such. We had a comment saying we'd do that but we weren't.

Test Plan

Test-booted ISO image under both UEFI and BIOS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benno created this revision.Mar 23 2018, 9:31 PM
Harbormaster completed remote builds in B15749: Diff 40655.Mar 23 2018, 9:31 PM
imp accepted this revision.Mar 23 2018, 9:36 PM

Does what it says...

Warner

This revision is now accepted and ready to land.Mar 23 2018, 9:36 PM
emaste added a comment.Mar 23 2018, 9:39 PM

Worth comparing with NetBSD's?

benno added a comment.Mar 23 2018, 9:44 PM

NetBSD seem to attempt this but it looks like they're actually modifying the last ET_ENTRY_SE entry, not ET_ENTRY_SH. I'm not sure how correct that is.

Closed by commit rS331467: Correctly mark the last El Torito section header. (authored by benno). · Explain WhyMar 23 2018, 10:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
makefs/
cd9660/
12 lines

Diff 40658

View Options

head/usr.sbin/makefs/cd9660/cd9660_eltorito.c

Loading...