Correctly mark last section header in El Torito catalog
ClosedPublic
Actions

Authored by benno on Mar 23 2018, 9:31 PM.

Tags

None

Referenced Files

	F107931030: D14812.id40658.diff
	Sun, Jan 19, 3:11 PM

	F107928351: D14812.id.diff
	Sun, Jan 19, 2:09 PM

	Unknown Object (File)
	Fri, Jan 17, 8:39 PM

	Unknown Object (File)
	Fri, Jan 17, 1:46 PM

	Unknown Object (File)
	Wed, Jan 8, 11:11 PM

	Unknown Object (File)
	Tue, Dec 31, 1:07 PM

	Unknown Object (File)
	Mon, Dec 30, 8:04 PM

	Unknown Object (File)
	Dec 13 2024, 5:56 AM

View All 64 Files

Subscribers

None

Details

Reviewers

emaste
imp

Commits

rS331467: Correctly mark the last El Torito section header.

Summary

The final section header in the El Torito catalog should be marked as such. We had a comment saying we'd do that but we weren't.

Test Plan

Test-booted ISO image under both UEFI and BIOS.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

benno created this revision.Mar 23 2018, 9:31 PM

Harbormaster completed remote builds in B15749: Diff 40655.Mar 23 2018, 9:31 PM

Does what it says...

Warner

This revision is now accepted and ready to land.Mar 23 2018, 9:36 PM

Worth comparing with NetBSD's?

NetBSD seem to attempt this but it looks like they're actually modifying the last ET_ENTRY_SE entry, not ET_ENTRY_SH. I'm not sure how correct that is.

Closed by commit rS331467: Correctly mark the last El Torito section header. (authored by benno). · Explain WhyMar 23 2018, 10:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

makefs/

cd9660/

cd9660_eltorito.c

12 lines

Diff 40658

View Options

head/usr.sbin/makefs/cd9660/cd9660_eltorito.c

Correctly mark last section header in El Torito catalogClosedPublicActions