deskutils/fbreader: upgrade to 0.99.6 - upgrade to 0.99.6 - use GitHub as MASTER_SITE - use Options helpers PR: 187819 Submitted by: myself Approved by: maintainer timeout (50 weeks) Approved by: koobs (mentor)
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
deskutils/fbreader/Makefile | ||
---|---|---|
16–27 | Probably better names "GUI" ? Also, you can give a group option a short title with GUI_DESC="Frontend GUI" or similar | |
34–35 | Sort these | |
36–44 | Group USE_* options and sort by alpha | |
46 | I think you want GTK2_USE= GNOME=gtk20 ? | |
49 | Fix case: QT4_USE= QT4= | |
49 | Is this necessary? (See next comment) | |
50 | Is this better scoped as QT4_LIBS ? | |
51 | Is LIBDIR=${PREFIX}/lib needed if LDFLAGS is set and vice-versa? | |
53 | Is LIBDIR=${PREFIX}/lib needed if LDFLAGS is set and vice-versa? |
deskutils/fbreader/Makefile | ||
---|---|---|
65 | Is this needed since we set MAKE_ARGS+= MAKE=${MAKE_CMD} or vice-versa? |
deskutils/fbreader/Makefile | ||
---|---|---|
16–27 | Unnecessary, as this is only used by the ports framework... | |
49 | doesn't build otherwise. | |
49 | Upcasing is done in bsd.options.mk regardless; convention has it to use lower-case values. See chapter 5.12.3.2. OPT_USE of Porter's Handbook | |
50 | Nope | |
51 | Yes, so that it can be propagated to the real/gmake. | |
65 | Yes, the call isn't to '${MAKE}' but to 'make'. |
deskutils/fbreader/Makefile | ||
---|---|---|
16–27 | I don't understand what 'unnecessary' means in this context. Please clarify. One interpretation is that it's only valuable for ports (and not packages). If this is the case, it still has user value. If not, again please clarify .. When option FOO is a group (single, multi, radio, etc), the group title shows up as the value of OPT_DESC in the dialog | |
50 | Please clarify .. |
deskutils/fbreader/Makefile | ||
---|---|---|
50 | OPT_LIBS is now supported by options helpers, but the question was whether it would be *better* scoped in LIBS, rather than LDFLAGS, which goes to ordering of flags among other things. |