It introduces Uses/fpc.mk and move all fpc-ports to USES=fpc
Details
Details
- Reviewers
- None
- Group Reviewers
portmgr O5: Ports Framework (Owns No Changed Paths) - Commits
- rP466532: - Migrate Mk/bsd.fpc.mk to Mk/Uses/fpc.mk
Tested on head
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
| Mk/Uses/fpc.mk | ||
|---|---|---|
| 42–50 | You should add DEV_WARNINGS if the WANT_* variables are set, so that they get removed. | |
| 103 | Same here, USE_FPC=yes should give a warning. | |
| 203 | Why did you remove the _POST component? Is it never needed? | |
Comment Actions
- Add DEV_WARNINGS
- Add check of fpc_ARGS
- USE_FPC warning is into bsd.port.mk
- I think that _POST variable is not necessary because it doesn't rewrite any target
| Mk/Uses/fpc.mk | ||
|---|---|---|
| 223 | That can probably be removed. | |
| Mk/Uses/fpc.mk | ||
|---|---|---|
| 10–12 | This is not required, there is a MAINTAINER line, any unauthorized commits can (and will) be backed out. | |
| 14–16 | This is a bit strange. It would probably be better to move the first sentence at the top, after "Support for FPC-...", and move the description of USE_FPC after the arguments description. | |
| 46–57 | As you already removed all uses of USE_FPC_RUN, WANT_FPC_BASE and WANT_FPC_ALL, so it would probably be best to remove support for them completely, and change the warnings into errors and put them in Mk/bsd.sanity.mk. | |
| Mk/bsd.port.mk | ||
| 1380–1383 | Unless I missed something, you added USES=fpc to all ports using USE_FPC, so this can be removed. (And the bit of doc about USE_FPC at the top of the file can go too.) | |
Comment Actions
- Remove not necessary messages
- Move WARNING message to Mk/bsd.sanity.mk
- Remove lines about USE_FPC from Mk/bsd.port.mk
- Some another changes
Comment Actions
I cannot find anything more to add or ask, so...
I do not remember seeing an exp-run request for this, but be sure to ask for one before committing the patch.