Page MenuHomeFreeBSD

Move Mk/bsd.fpc.mk to Mk/Uses/fpc.mk
ClosedPublic

Authored by acm on Mar 8 2018, 5:42 AM.

Details

Reviewers
None
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Commits
rP466532: - Migrate Mk/bsd.fpc.mk to Mk/Uses/fpc.mk
Summary

It introduces Uses/fpc.mk and move all fpc-ports to USES=fpc

Test Plan

Tested on head

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Mk/Uses/fpc.mk
42–50

You should add DEV_WARNINGS if the WANT_* variables are set, so that they get removed.
You do not seem to be doing any checks to the content of fpc_ARGS, you should add some.

103

Same here, USE_FPC=yes should give a warning.

203

Why did you remove the _POST component? Is it never needed?

  • Add DEV_WARNINGS
  • Add check of fpc_ARGS
  • USE_FPC warning is into bsd.port.mk
  • I think that _POST variable is not necessary because it doesn't rewrite any target
acm marked 2 inline comments as done.Mar 11 2018, 9:43 PM
Mk/Uses/fpc.mk
205

That can probably be removed.

acm marked an inline comment as done.
  • Remove line from end of file
Mk/Uses/fpc.mk
10–11

This is not required, there is a MAINTAINER line, any unauthorized commits can (and will) be backed out.

13–16

This is a bit strange. It would probably be better to move the first sentence at the top, after "Support for FPC-...", and move the description of USE_FPC after the arguments description.

40–51

As you already removed all uses of USE_FPC_RUN, WANT_FPC_BASE and WANT_FPC_ALL, so it would probably be best to remove support for them completely, and change the warnings into errors and put them in Mk/bsd.sanity.mk.

Mk/bsd.port.mk
1376–1377

Unless I missed something, you added USES=fpc to all ports using USE_FPC, so this can be removed. (And the bit of doc about USE_FPC at the top of the file can go too.)

acm marked 4 inline comments as done.Mar 12 2018, 6:08 PM
  • Remove not necessary messages
  • Move WARNING message to Mk/bsd.sanity.mk
  • Remove lines about USE_FPC from Mk/bsd.port.mk
  • Some another changes

I cannot find anything more to add or ask, so...

I do not remember seeing an exp-run request for this, but be sure to ask for one before committing the patch.

  • Revert editors/lazarus to 1.8.0
This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 4:52 AM
This revision was automatically updated to reflect the committed changes.