lualoader: Expose loader.parse and add cli.parse_and_execute
ClosedPublic
Actions

Authored by kevans on Mar 4 2018, 2:48 AM.

Details

Reviewers

cem
imp

Commits

rS330616: lualoader: Expose loader.parse and add cli_execute_unparsed

Summary

This will be used for scenarios where the command to execute is coming in via the environment (from, for example, loader.conf(5)) and is thus not necessarily trusted.

parse_and_execute will immediately be used for handling module_{before,after,error} as well as menu_timeout_command. We still want to offer these variables the ability to execute Lua-intercepted loader commands, but we don't want them to be able to execute arbitrary Lua.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Mar 4 2018, 2:48 AM

I should probably add a note to 'cli' that most of these functions will violate our standard naming convention... loader commands tend to use hyphens or underscore to separate words, so functions that may be executed at the loader prompt should follow suit.

imp accepted this revision.Mar 7 2018, 5:23 PM

This revision is now accepted and ready to land.Mar 7 2018, 5:23 PM

Closed by commit rS330616: lualoader: Expose loader.parse and add cli_execute_unparsed (authored by kevans). · Explain WhyMar 7 2018, 6:25 PM

This revision was automatically updated to reflect the committed changes.