Differential D1976

Memory leaks in eui64_line()
ClosedPublic
Actions

Authored by pfg on Feb 27 2015, 2:16 AM.

Details

Reviewers

brooks
delphij

Summary

According to Coverity, there are memory leaks for cur and linehead.

The "bad" label would indicate that effectively linehead seems to need
freeing. It doesn't seem to hurt to free "cur" also.

Test Plan

IPV6

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

pfg updated this revision to Diff 4003.Feb 27 2015, 2:16 AM

pfg retitled this revision from to Memory leaks in eui64_line() According to Coverity, there are memory leaks for cur and linehead. The "bad" label would indicate that effectively linehead seems to need freeing. It doesn't seem to hurt to free "cur" also..

pfg updated this object.

pfg edited the test plan for this revision. (Show Details)

pfg added a reviewer: delphij.

The proposed patch is wrong. 'cur' is never leaked because it's not a new allocation.

lib/libc/net/eui64.c
135	This is WRONG. cur should not be freed because it's part of line[head].

This revision now requires changes to proceed.Feb 27 2015, 2:29 AM

delphij added a reviewer: brooks.Feb 27 2015, 2:42 AM

Makes sense: the normal return free() matches the bad label now.

Thanks!

delphij accepted this revision.Feb 27 2015, 3:14 AM

delphij edited edge metadata.

This revision is now accepted and ready to land.Feb 27 2015, 3:14 AM

Looks good to me.

Thank you for reviewing!

Committed as revision 279363.

Revision Contents
Changeset List

Path

Size

lib/

libc/

net/

eui64.c

2 lines

Diff 4003

View Options

Memory leaks in eui64_line()ClosedPublicActions