Page MenuHomeFreeBSD

Fix the problem described in PR #226221. (I think)
ClosedPublic

Authored by mat on Feb 27 2018, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 4:42 PM
Unknown Object (File)
Sun, Apr 14, 2:10 AM
Unknown Object (File)
Fri, Apr 12, 4:44 AM
Unknown Object (File)
Dec 20 2023, 5:28 AM
Unknown Object (File)
Dec 4 2023, 3:49 PM
Unknown Object (File)
Nov 5 2023, 12:43 AM
Unknown Object (File)
Nov 4 2023, 7:32 AM
Unknown Object (File)
Oct 30 2023, 11:28 PM
Subscribers
None

Details

Summary

The problem is that GH_SUBDIR are handled in a somewhat random manner. (The
truth is that in the end of things, they end up being sorted by the group name
being used in the GH_TUPLE.)

So if you have a submodule in bar/foo, and a sub-submodule in bar/foo/baz, it
may happen that foo/bar/baz is handled before foo/bar and then things are
messed up.

This makes it so the GH_SUBDIR target handling is sorted first by the
number of / in the path. (So, bar/foo is always handled before
bar/foo/baz.)

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15300
Build 15358: arc lint + arc unit

Event Timeline

  • currently should not be used.

Looks good to me, though I am not a ports committer (yet), so it would be better to have someone else to review it :-)

This revision is now accepted and ready to land.Feb 27 2018, 7:16 PM
In D14532#304868, @ygy wrote:

Looks good to me, though I am not a ports committer (yet), so it would be better to have someone else to review it :-)

But does it fix the problem you are experiencing?

In D14532#305009, @mat wrote:
In D14532#304868, @ygy wrote:

Looks good to me, though I am not a ports committer (yet), so it would be better to have someone else to review it :-)

But does it fix the problem you are experiencing?

I did the test against my working port, and this patch worked beautifully. Thanks!

This revision was automatically updated to reflect the committed changes.