Page MenuHomeFreeBSD

powerpc64: Remove unused variables avoid gcc warnings
Needs ReviewPublic

Authored by breno.leitao_gmail.com on Feb 23 2018, 6:52 PM.
Tags
None
Referenced Files
F81655103: D14487.id39650.diff
Fri, Apr 19, 1:04 PM
Unknown Object (File)
Wed, Apr 17, 4:26 AM
Unknown Object (File)
Thu, Apr 11, 1:30 PM
Unknown Object (File)
Sat, Mar 30, 8:29 PM
Unknown Object (File)
Feb 20 2024, 6:27 PM
Unknown Object (File)
Feb 15 2024, 8:50 PM
Unknown Object (File)
Jan 8 2024, 1:44 AM
Unknown Object (File)
Jan 2 2024, 7:35 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Compiling the powerpc64 kernel with a newer GCC generates some annoying
messages, as unused and uninitialized variables.

This patchset fixes these warnings and this patchset shouldn't cause any change
in the code.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15277
Build 15336: arc lint + arc unit

Event Timeline

sys/powerpc/cpufreq/pmufreq.c
116–117

This line can just be deleted.

sys/powerpc/pseries/phyp_llan.c
159

I think this is incorrect, and error should be handled.

187

Don't ignore it, handle it.

318

Error should be handled, not ignored.

Resubmitting a code that treats the errors other than ignoring them,.

sys/powerpc/pseries/phyp_llan.c
194

You need to clean up the resource allocations when you exit prematurely. Often there'll be a label at the end of the function to do cleanup before returning error.

338

Is there any cleanup needed from the H_FREE_LOGICAL_LAN call if this second hcall fails?