Differential D11013

Fix numerous Coverity issues in mptutil
ClosedPublic
Actions

Authored by asomers on May 31 2017, 4:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 12, 6:15 AM

	Unknown Object (File)
	Mon, May 6, 9:50 AM

	Unknown Object (File)
	Fri, May 3, 10:50 AM

	Unknown Object (File)
	Wed, May 1, 5:36 PM

	Unknown Object (File)
	Sat, Apr 27, 6:47 PM

	Unknown Object (File)
	Apr 14 2024, 5:26 PM

	Unknown Object (File)
	Apr 8 2024, 1:53 PM

	Unknown Object (File)
	Mar 12 2024, 11:08 AM

View All 27 Files

Subscribers

Details

Reviewers

Commits

rS332603: MFC r329845, r329872
rS329845: Fix numerous Coverity issues in mptutil

Summary

Fix numerous Coverity issues in mptutil

Most are memory or file descriptor leaks. Three were unannotated
fallthroughs in a switch/case statement. One was an integer overflow before
widen.

Reported by: Coverity
CID: 1007463 1007462 1007461 1007460 1007459 1007458 1007457
CID: 1006855 1006854 1006853 1006852 1006851 1006850 1006849
CID: 1006848 1006845 1006844 1006843 1006842 1006841 1006840
CID: 1006839 1006838 1006837 1006836 1006835 1006834 1006833
CID: 1006832 1006831 1006831 1006830 1006829 1008334 1008170
CID: 1008169 1008168

Test Plan

I don't have the hardware. Scott, are you able to test these
changes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.May 31 2017, 4:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2017, 4:54 PM

Harbormaster completed remote builds in B9609: Diff 29094.May 31 2017, 4:54 PM

@scottl @imp can either of you test this change? If not, I'll abandon it.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2018, 12:18 AM

Closed by commit rS329845: Fix numerous Coverity issues in mptutil (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

mptutil/

85 lines

39 lines

8 lines

10 lines

13 lines

Diff 39625

head/usr.sbin/mptutil/mpt_config.c

Loading...

head/usr.sbin/mptutil/mpt_drive.c

Loading...

head/usr.sbin/mptutil/mpt_evt.c

Loading...

head/usr.sbin/mptutil/mpt_show.c

Loading...

head/usr.sbin/mptutil/mpt_volume.c

Loading...