Add all py-certbot plugins.
ClosedPublic
Actions

Authored by mat on Feb 8 2018, 10:52 AM.

Details

Reviewers

skreuzer
koobs
cpm

Group Reviewers

Python

Commits

Summary

Also add a few required port updates.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mat created this revision.Feb 8 2018, 10:52 AM

Harbormaster completed remote builds in B14868: Diff 39039.Feb 8 2018, 10:52 AM

Add py-certbot-dns-route53, Route53 DNS Authenticator for py-certbot.

Harbormaster completed remote builds in B14869: Diff 39040.Feb 8 2018, 10:54 AM

Add a few individuals for port updates:

@skreuzer for www/py-python-digitalocean
@koobs for security/py-certbot
@cpm for security/py-acme

ah sorry. I also had a bugzilla PR assigned me to update this port. I didn't see this diff until after I updated the port.

This revision is now accepted and ready to land.Feb 8 2018, 4:12 PM

@mat

Thanks for working on this!

The ports look good to me. I only have suggestions of COMMENT and pkg-descr. Thanks!

security/py-certbot-apache/Makefile
10 ↗	(On Diff #39040)	People should already know what Certbot is when he/she tries to install the plugin port. Since it's a plugin port, I would suggest to use "Apache plugin for Certbot" from its setup.py. It also applies to other plugin ports.
security/py-certbot-apache/pkg-descr
1–2 ↗	(On Diff #39040)	Can we remove this line?
3–8 ↗	(On Diff #39040)	Do we need description of Certbot in the pkg-descr of each plugin ports? Can we just use "This is the Apache plugin of Certbot (security/py-certbot)" instead?

In D14262#299543, @cpm wrote:

@mat

Thanks for working on this!

Would you mind terribly if py-acme was given to python@ ? So that it is easier to update the whole suite of ports ? (Same question for @koobs and py-certbot)

In D14262#300439, @mat wrote:

In D14262#299543, @cpm wrote:

@mat

Thanks for working on this!

Would you mind terribly if py-acme was given to python@ ? So that it is easier to update the whole suite of ports ? (Same question for @koobs and py-certbot)