Page MenuHomeFreeBSD

Add all py-certbot plugins.
ClosedPublic

Authored by mat on Feb 8 2018, 10:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 3:04 AM
Unknown Object (File)
Nov 25 2024, 11:48 AM
Unknown Object (File)
Nov 24 2024, 8:58 AM
Unknown Object (File)
Nov 24 2024, 7:39 AM
Unknown Object (File)
Nov 22 2024, 11:23 PM
Unknown Object (File)
Nov 22 2024, 10:32 PM
Unknown Object (File)
Nov 22 2024, 6:50 AM
Unknown Object (File)
Nov 21 2024, 3:55 PM

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14868
Build 14981: arc lint + arc unit

Event Timeline

  • Add py-certbot-dns-route53, Route53 DNS Authenticator for py-certbot.
mat added subscribers: cpm, koobs, skreuzer.

Add a few individuals for port updates:

  • @skreuzer for www/py-python-digitalocean
  • @koobs for security/py-certbot
  • @cpm for security/py-acme

ah sorry. I also had a bugzilla PR assigned me to update this port. I didn't see this diff until after I updated the port.

This revision is now accepted and ready to land.Feb 8 2018, 4:12 PM

@mat

Thanks for working on this!

The ports look good to me. I only have suggestions of COMMENT and pkg-descr. Thanks!

security/py-certbot-apache/Makefile
11

People should already know what Certbot is when he/she tries to install the plugin port.
Since it's a plugin port, I would suggest to use "Apache plugin for Certbot" from its setup.py.

It also applies to other plugin ports.

security/py-certbot-apache/pkg-descr
2–3

Can we remove this line?

4–9

Do we need description of Certbot in the pkg-descr of each plugin ports?
Can we just use "This is the Apache plugin of Certbot (security/py-certbot)" instead?

In D14262#299543, @cpm wrote:

@mat

Thanks for working on this!

Would you mind terribly if py-acme was given to python@ ? So that it is easier to update the whole suite of ports ? (Same question for @koobs and py-certbot)

In D14262#300439, @mat wrote:
In D14262#299543, @cpm wrote:

@mat

Thanks for working on this!

Would you mind terribly if py-acme was given to python@ ? So that it is easier to update the whole suite of ports ? (Same question for @koobs and py-certbot)

I totally agree. I will drop maintainership for security/py-acme and security/py-josepy ports to give them to python@

This revision was automatically updated to reflect the committed changes.