Page MenuHomeFreeBSD
Differential D14451

Lua lfs.attributes: Provide a more consistent error return
ClosedPublic
Actions

Authored by cem on Feb 20 2018, 5:46 PM.
Tags
None
Referenced Files
F137618179: D14451.id39532.diff
Mon, Nov 24, 3:36 PM
F137587425: D14451.id39529.diff
Mon, Nov 24, 11:22 AM
F137520442: D14451.diff
Mon, Nov 24, 3:27 AM
F137472834: D14451.diff
Sun, Nov 23, 7:13 PM
Unknown Object (File)
Mon, Nov 3, 5:41 PM
Unknown Object (File)
Mon, Nov 3, 5:41 PM
Unknown Object (File)
Mon, Nov 3, 5:41 PM
Unknown Object (File)
Mon, Nov 3, 12:46 PM
View All 68 Files
Subscribers
None

Details

Reviewers
imp
kevans
Commits
rS329649: Lua lfs.attributes: Provide a more consistent error return
Summary

In remaining error case, return 3-tuple consistent with the other error return
case.

Document how to invoke lfs.attributes() and detect/decode error return in
example comments.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem created this revision.Feb 20 2018, 5:46 PM
kevans accepted this revision.Feb 20 2018, 6:18 PM

+1 for consistency; it also feels like we should expose errno constants somewhere to lua, because that doesn't seem to be a thing at the moment.

This revision is now accepted and ready to land.Feb 20 2018, 6:18 PM
Closed by commit rS329649: Lua lfs.attributes: Provide a more consistent error return (authored by cem). · Explain WhyFeb 20 2018, 6:21 PM
This revision was automatically updated to reflect the committed changes.
cem added a comment.Feb 20 2018, 6:22 PM
In D14451#302892, @kevans wrote:

+1 for consistency; it also feels like we should expose errno constants somewhere to lua, because that doesn't seem to be a thing at the moment.

+1

Revision Contents
Changeset List

PathSize
head/
stand/
liblua/
17 lines

Diff 39532

View Options

head/stand/liblua/lfs.c

Loading...