Lua lfs.attributes: Provide a more consistent error return
ClosedPublic
Actions

Authored by cem on Feb 20 2018, 5:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 3:09 PM

	Unknown Object (File)
	Sat, Nov 23, 3:06 PM

	Unknown Object (File)
	Sat, Nov 23, 11:40 AM

	Unknown Object (File)
	Sat, Nov 23, 10:52 AM

	Unknown Object (File)
	Fri, Nov 22, 10:23 PM

	Unknown Object (File)
	Fri, Nov 22, 5:21 PM

	Unknown Object (File)
	Tue, Nov 19, 5:14 PM

	Unknown Object (File)
	Tue, Nov 19, 1:25 PM

View All 38 Files

Subscribers

None

Details

Reviewers

imp
kevans

Commits

rS329649: Lua lfs.attributes: Provide a more consistent error return

Summary

In remaining error case, return 3-tuple consistent with the other error return
case.

Document how to invoke lfs.attributes() and detect/decode error return in
example comments.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Feb 20 2018, 5:46 PM

+1 for consistency; it also feels like we should expose errno constants somewhere to lua, because that doesn't seem to be a thing at the moment.

This revision is now accepted and ready to land.Feb 20 2018, 6:18 PM

Closed by commit rS329649: Lua lfs.attributes: Provide a more consistent error return (authored by cem). · Explain WhyFeb 20 2018, 6:21 PM

This revision was automatically updated to reflect the committed changes.

In D14451#302892, @kevans wrote:

+1 for consistency; it also feels like we should expose errno constants somewhere to lua, because that doesn't seem to be a thing at the moment.

Revision Contents
Changeset List

Path

Size

head/

stand/

liblua/

lfs.c

17 lines

Diff 39532

View Options

Lua lfs.attributes: Provide a more consistent error returnClosedPublicActions