lualoader: Add ability to intercept cli commands
ClosedPublic
Actions

Authored by kevans on Feb 20 2018, 5:16 PM.

Details

Reviewers

imp

Commits

rS329644: lualoader: Add ability to intercept cli commands

Summary

If we failed to execute the input line as pure lua, run the command through parse for consistent argument parsing. Pass the parsed arguments through to a global "cli_execute" written in Lua, which is expected to either handle it or pass it back through to interp_builtin_cmd (via loader.command).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 15165

Event Timeline

kevans created this revision.Feb 20 2018, 5:16 PM

kevans added a parent revision: D14448: Prototype for loader.command.

imp added inline comments.Feb 20 2018, 5:20 PM

stand/common/interp_lua.c
149	This seems to have disappeared.

Don't add leaks that weren't there before

I'm good either way, but if you keep what you have a quick comment wouldn't be terrible.

stand/lua/loader.lua
42	was thinking this would just be cmd(...) for symmetry, though I suppose it doesn't matter much since the traditional reason for passing argv[0] isn't relevant here.

This revision is now accepted and ready to land.Feb 20 2018, 5:32 PM

Closed by commit rS329644: lualoader: Add ability to intercept cli commands (authored by kevans). · Explain WhyFeb 20 2018, 5:47 PM

This revision was automatically updated to reflect the committed changes.