Page MenuHomeFreeBSD
Differential D1946

improve buf_ring readability
AcceptedPublic
Actions

Authored by kmacy on Feb 23 2015, 1:47 AM.
Tags
None
Referenced Files
F82583377: D1946.diff
Tue, Apr 30, 3:25 PM
Unknown Object (File)
Mon, Apr 15, 3:45 AM
Unknown Object (File)
Feb 22 2024, 4:53 AM
Unknown Object (File)
Feb 19 2024, 10:29 AM
Unknown Object (File)
Jan 11 2024, 8:29 PM
Unknown Object (File)
Dec 13 2023, 4:51 PM
Unknown Object (File)
Dec 3 2023, 7:23 AM
Unknown Object (File)
Nov 19 2023, 3:43 PM
View All 42 Files
Subscribers
None

Details

Reviewers
zbb
rpaulo
imp
Summary

Factor out larger chunks of conditional code in to macros to improve the readability of enqueue and dequeue

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kmacy updated this revision to Diff 3918.Feb 23 2015, 1:47 AM
kmacy retitled this revision from to improve buf_ring readability.
kmacy updated this object.
kmacy edited the test plan for this revision. (Show Details)
kmacy added reviewers: imp, rpaulo, zbb.
kmacy updated this revision to Diff 3920.Feb 23 2015, 2:06 AM

make tabbing look more normal for 8 space tabs

kmacy updated this revision to Diff 3921.Feb 23 2015, 2:09 AM

Fix whitespace error in macro

rpaulo accepted this revision.Feb 23 2015, 3:24 AM
rpaulo edited edge metadata.

If no one objects, I'll commit it.

sys/sys/buf_ring.h
98

I think the style guide says the "do {" comes in the same line as the #define.

This revision is now accepted and ready to land.Feb 23 2015, 3:24 AM

Revision Contents
Changeset List

PathSize
sys/
sys/
69 lines

Diff 3920

View Options

sys/sys/buf_ring.h

Loading...