Page MenuHomeFreeBSD

stand/fdt: Rip out FDT VA tracking
ClosedPublic

Authored by kevans on Jan 30 2018, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 9:15 AM
Unknown Object (File)
Sat, Jun 29, 12:52 AM
Unknown Object (File)
Thu, Jun 27, 6:54 PM
Unknown Object (File)
Mon, Jun 24, 11:11 AM
Unknown Object (File)
Sun, Jun 16, 6:52 AM
Unknown Object (File)
May 22 2024, 11:22 AM
Unknown Object (File)
May 16 2024, 11:02 PM
Unknown Object (File)
Apr 4 2024, 6:15 PM
Subscribers
None

Details

Summary

Whether we should be overwriting the loaded FDT module with the 'fixed up' version or not was questionable when this was added, and now that overlays are possible this is downright wrong.

Overlays can increase the size of the blob, so writing it back to the original VA will generally write past the end of the block and start clobbering other things in memory.

Rip it out- it was questionable to begin with, it's doing bad things now, and it serves no purpose since the modified blob will be copied into place rather than relying on this to reflect the changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 14671

Event Timeline

This revision is now accepted and ready to land.Feb 1 2018, 6:02 AM
This revision was automatically updated to reflect the committed changes.