Page MenuHomeFreeBSD
Differential D14116

new port: devel/bats
ClosedPublic
Actions

Authored by lifanov on Jan 29 2018, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 4:20 PM
Unknown Object (File)
Mon, Sep 7, 11:18 PM
Unknown Object (File)
Mon, Aug 24, 10:18 PM
Unknown Object (File)
Aug 22 2026, 8:01 AM
Unknown Object (File)
Aug 20 2026, 12:01 PM
Unknown Object (File)
Aug 11 2026, 10:47 AM
Unknown Object (File)
Aug 8 2026, 7:39 PM
Unknown Object (File)
Aug 8 2026, 7:34 PM
View All Files
Subscribers
None

Details

Reviewers
mat
matthew
Commits
rP460497: new port: devel/bats
Summary

bats is an automated testing framework for bash

Test Plan
portlint -A - OK
poudriere testport - OK
functionality - OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14652
Build 14782: arc lint + arc unit

Event Timeline

lifanov created this revision.Jan 29 2018, 2:45 PM
lifanov updated this revision to Diff 38619.Jan 29 2018, 4:06 PM

fix executing from $PATH: bin/bats needs to be a symlink

https://github.com/sstephenson/bats/blob/master/bin/bats

mat added a comment.Jan 29 2018, 4:17 PM

Also, unless this is a problem, I would encourage you to install the scripts in a subdirectory of libexec, and not directly in it.

devel/bats/Makefile
38
${RLN} ${STAGEDIR}/libexec/bats ${STAGEDIR}${PREFIX}/bin/bats
lifanov updated this revision to Diff 38628.Jan 29 2018, 5:44 PM

address mat's feedback:

o use ${RLN}
o move libexec scripts to libexec/bats

Although this is different from upstream install layout,
moving scripts under libexec/bats still works and there
is no issue running tests.

Harbormaster completed remote builds in B14657: Diff 38628.Jan 29 2018, 5:44 PM
lifanov marked an inline comment as done.Jan 29 2018, 5:45 PM
mat added inline comments.Jan 30 2018, 8:02 AM
devel/bats/Makefile
19

I doubt this works, SHEBANG_FILES is relative to WRKSRC.

lifanov marked an inline comment as done.Jan 30 2018, 2:09 PM

This does work. These files are in ${WRKSRC}/libexec: https://github.com/sstephenson/bats

mat added a comment.Jan 30 2018, 3:15 PM
In D14116#296465, @lifanov wrote:

This does work. These files are in ${WRKSRC}/libexec: https://github.com/sstephenson/bats

Oh, yes, sorry, my brain somehow read ${SCRIPTS:S/^/libexec\/${PORTNAME}\//}...

This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2018, 4:30 PM
Closed by commit rP460497: new port: devel/bats (authored by lifanov). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
bats/
45 lines
3 lines
4 lines

Diff 38619

View Options

devel/bats/

Loading...
View Options

devel/bats/Makefile

Loading...
View Options

devel/bats/distinfo

Loading...
View Options

devel/bats/pkg-descr

Loading...