Paths

Table of Contentst

deskutils/flameshot: Drop USE_GCC and add missing build dependency
ClosedPublic
Actions

Authored by rakuco on Jan 28 2018, 10:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 6, 11:40 PM

	Unknown Object (File)
	Sat, Apr 27, 3:34 AM

	Unknown Object (File)
	Wed, Apr 24, 9:38 PM

	Unknown Object (File)
	Tue, Apr 23, 7:00 PM

	Unknown Object (File)
	Tue, Apr 23, 2:46 PM

	Unknown Object (File)
	Tue, Apr 23, 2:46 PM

	Unknown Object (File)
	Tue, Apr 23, 2:43 PM

	Unknown Object (File)
	Sun, Apr 21, 1:51 AM

View All 42 Files

Subscribers

mat

Details

Reviewers

nivit
antoine

Commits

rP460819: Drop USE_GCC and add missing build dependency

Summary

Backport an upstream commit that fixes the build with clang, which allows us to drop USE_GCC. It is broken on at least FreeBSD 10:

===>  Configuring for flameshot-0.5.0
Project ERROR: Cannot run compiler 'g++'. Output:
===================
g++: not found
===================
Maybe you forgot to setup the environment?
*** Error code 3

Also add a dependency on qt5-buildtools, otherwise the build complains that rcc is not found.

Test Plan

The port builds fine on 10.3.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rakuco created this revision.Jan 28 2018, 10:45 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 28 2018, 10:45 PM

antoine accepted this revision.Feb 3 2018, 12:06 PM

This revision is now accepted and ready to land.Feb 3 2018, 12:06 PM

Closed by commit rP460819: Drop USE_GCC and add missing build dependency (authored by rakuco). · Explain WhyFeb 3 2018, 3:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

deskutils/

flameshot/

Makefile

5 lines

files/

patch-git_481069

25 lines

Diff 38589

View Options

deskutils/flameshot/Makefile