Page MenuHomeFreeBSD
Differential D1878

Add function to force an nvlist into the error state
ClosedPublic
Actions

Authored by rstone on Feb 17 2015, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 9:32 AM
Unknown Object (File)
Mon, Mar 3, 10:32 AM
Unknown Object (File)
Mon, Mar 3, 8:47 AM
Unknown Object (File)
Mon, Mar 3, 7:44 AM
Unknown Object (File)
Mon, Feb 24, 4:19 PM
Unknown Object (File)
Mon, Feb 24, 3:15 PM
Unknown Object (File)
Sun, Feb 23, 1:33 PM
Unknown Object (File)
Sun, Feb 16, 8:07 AM
View All Files
Subscribers
freebsd-net-list
pjd

Details

Reviewers
jfv
Commits
rS279434: Add function to force an nvlist into the error state
Summary

Add an nvlist_set_error() function that can be used to force an
nvlist into the error state. This is useful both for writing
tests and for writing APIs that use nvlists internally.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rstone updated this revision to Diff 3821.Feb 17 2015, 5:44 PM
rstone retitled this revision from to Add function to force an nvlist into the error state.
rstone edited the test plan for this revision. (Show Details)
rstone added a reviewer: jfv.
rstone updated this object.
rstone added subscribers: pjd, Unknown Object (MLST).
jfv accepted this revision.Feb 18 2015, 10:25 PM
jfv edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2015, 10:25 PM
pjd added a comment.Feb 19 2015, 8:44 AM

Other that the minor nit above, it looks good.

lib/libnv/nvlist.c
144

I'd assert that error is != 0.

rstone closed this revision.Feb 20 2015, 1:22 AM

Revision Contents
Changeset List

PathSize
lib/
libnv/
1 line
1 line
14 lines
8 lines
tests/
36 lines

Diff 3821

View Options

lib/libnv/Makefile

Loading...
View Options

lib/libnv/nv.h

Loading...
View Options

lib/libnv/nv.3

Loading...
View Options

lib/libnv/nvlist.c

Loading...
View Options

lib/libnv/tests/nv_tests.cc

Loading...