Page MenuHomeFreeBSD
Differential D13868

Use XPT_GET_ADVINFO for retrieving MMC params
ClosedPublic
Actions

Authored by scottl on Jan 11 2018, 6:07 PM.
Tags
None
Referenced Files
F169984879: D13868.id.diff
Thu, Sep 3, 4:42 AM
Unknown Object (File)
Tue, Sep 1, 1:02 PM
Unknown Object (File)
Tue, Sep 1, 12:56 PM
Unknown Object (File)
Tue, Sep 1, 3:52 AM
Unknown Object (File)
Tue, Sep 1, 2:45 AM
Unknown Object (File)
Sun, Aug 30, 12:39 PM
Unknown Object (File)
Sun, Aug 30, 10:11 AM
Unknown Object (File)
Sun, Aug 30, 10:05 AM
View All Files
Subscribers
None

Details

Reviewers
imp
kibab
Commits
rS328165: Revert ABI breakage to CAM that came in with MMC/SD support in r320844.
Summary

Fix the accidental ABI breakage for CCBs and use the ADVINFO CCB
for retrieving the mmc_params structure.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

scottl created this revision.Jan 11 2018, 6:07 PM
Harbormaster completed remote builds in B14308: Diff 37822.Jan 11 2018, 6:07 PM
imp added a comment.Jan 11 2018, 6:23 PM

This looks good to me, modulo my one question...
I'll test it out shortly.

sys/cam/mmc/mmc_xpt.c
373 ↗(On Diff #37822)

I assume the ioctl takes care of setting up the kernel buffer for this, then copying it out to user space?

scottl added inline comments.Jan 11 2018, 6:32 PM
sys/cam/mmc/mmc_xpt.c
373 ↗(On Diff #37822)

I believe it's handled automatically in cam_periph_mapmem()

scottl added a reviewer: kibab.Jan 19 2018, 7:05 AM
kibab accepted this revision.Jan 19 2018, 2:23 PM

This change LGTM, I would like to know how this was discovered?

This revision is now accepted and ready to land.Jan 19 2018, 2:23 PM
Closed by commit rS328165: Revert ABI breakage to CAM that came in with MMC/SD support in r320844. (authored by scottl). · Explain WhyJan 19 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.
scottl mentioned this in rS328165: Revert ABI breakage to CAM that came in with MMC/SD support in r320844..
scottl added a comment.Jan 19 2018, 3:33 PM

I came across it during some other clean-up work.

Revision Contents
Changeset List

PathSize
head/
sbin/
camcontrol/
42 lines
sys/
cam/
2 lines
3 lines
mmc/
7 lines

Diff 38208

View Options

head/sbin/camcontrol/camcontrol.c

Loading...
View Options

head/sys/cam/cam_ccb.h

Loading...
View Options

head/sys/cam/cam_xpt.c

Loading...
View Options

head/sys/cam/mmc/mmc_xpt.c

Loading...