Page MenuHomeFreeBSD
Differential D13839

Fix minor locking issues in the PowerMac Uninorth PCI driver
ClosedPublic
Actions

Authored by landonf on Jan 10 2018, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 28, 6:09 AM
Unknown Object (File)
Mon, Apr 27, 7:30 PM
Unknown Object (File)
Sun, Apr 12, 1:10 PM
Unknown Object (File)
Sun, Apr 12, 11:41 AM
Unknown Object (File)
Sat, Apr 11, 11:24 AM
Unknown Object (File)
Sat, Apr 11, 1:21 AM
Unknown Object (File)
Mon, Apr 6, 4:00 AM
Unknown Object (File)
Sun, Apr 5, 2:12 PM
View All Files
Subscribers
imp

Details

Reviewers
jhibbits
Commits
rS327798: Fix minor locking issues in the Power Mac Uninorth PCI bridge driver.
Summary
  • Call resource_int_value() once during attach, rather than within the pci_(read|write)_config() code path; this avoids taking a blocking mutex to read kenv variables.
  • Use a spin lock to protect non-atomic config space accesses (this matches the behavior of the Darwin AppleMacRiscPCI driver).
Test Plan

Tested for regressions on a PowerBook5,8.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14269
Build 14429: arc lint + arc unit

Event Timeline

landonf created this revision.Jan 10 2018, 9:26 PM
Harbormaster completed remote builds in B14269: Diff 37757.Jan 10 2018, 9:26 PM
landonf updated this revision to Diff 37760.Jan 10 2018, 9:37 PM
  • Add mtx_assert(MA_OWNED) to uninorth_enable_config() for good measure.
Harbormaster completed remote builds in B14272: Diff 37760.Jan 10 2018, 9:37 PM
jhibbits accepted this revision.Jan 10 2018, 9:41 PM
jhibbits added inline comments.
sys/powerpc/powermac/uninorthvar.h
43

Match whitespace? Might be phabricator messing with it, but just double check.

This revision is now accepted and ready to land.Jan 10 2018, 9:41 PM
landonf marked an inline comment as done.Jan 10 2018, 9:42 PM
landonf added inline comments.
sys/powerpc/powermac/uninorthvar.h
43

Yeah, looks like phabricator behaving badly.

Closed by commit rS327798: Fix minor locking issues in the Power Mac Uninorth PCI bridge driver. (authored by landonf). · Explain WhyJan 10 2018, 10:19 PM
This revision was automatically updated to reflect the committed changes.
landonf marked an inline comment as done.
Herald added a subscriber: imp. · View Herald TranscriptJan 10 2018, 10:19 PM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
powermac/
33 lines
2 lines

Diff 37757

View Options

sys/powerpc/powermac/uninorthpci.c

Loading...
View Options

sys/powerpc/powermac/uninorthvar.h

Loading...