Include required ofw_gpiobus.c when building gpiobus module for OFW/FDT targets.
AbandonedPublic
Actions

Authored by landonf on Jan 10 2018, 8:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 27, 11:01 PM

	Unknown Object (File)
	Oct 28 2025, 11:34 PM

	Unknown Object (File)
	Oct 26 2025, 2:12 AM

	Unknown Object (File)
	Oct 3 2025, 5:18 PM

	Unknown Object (File)
	Sep 30 2025, 4:41 PM

	Unknown Object (File)
	Sep 30 2025, 7:40 AM

	Unknown Object (File)
	Sep 29 2025, 5:25 PM

	Unknown Object (File)
	Sep 29 2025, 11:24 AM

View All 49 Files

Subscribers

loos

Details

Reviewers

jhibbits
adrian

Summary

On FDT systems, gpiobus.c depends on ofw_gpiobus_register_provider() and
ofw_gpiobus_unregister_provider() from ofw_gpiobus.c; this file is included
in the kernel build if 'device gpio' is enabled, but is not inluded in the
module build.

Apologies for asking for a review of a three-liner; I just didn't want to
stomp on anything outside my purview.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14263
Build 14424: arc lint + arc unit

Event Timeline

landonf created this revision.Jan 10 2018, 8:48 PM

Herald added a subscriber: loos. · View Herald TranscriptJan 10 2018, 8:48 PM

Already done, in r327681.

Whoops, I got beat to it :-)

Revision Contents
Changeset List

Path

Size

sys/

modules/

gpio/

gpiobus/

Makefile

4 lines

Diff 37749

View Options

sys/modules/gpio/gpiobus/Makefile

Include required ofw_gpiobus.c when building gpiobus module for OFW/FDT targets.AbandonedPublicActions