Page MenuHomeFreeBSD
Differential D13823

Retire pmtimer driver.
ClosedPublic
Actions

Authored by imp on Jan 10 2018, 6:18 AM.
Tags
None
Referenced Files
F135373293: D13823.id37716.diff
Sun, Nov 9, 5:41 AM
Unknown Object (File)
Thu, Oct 30, 6:26 AM
Unknown Object (File)
Thu, Oct 30, 6:26 AM
Unknown Object (File)
Thu, Oct 30, 6:26 AM
Unknown Object (File)
Thu, Oct 30, 6:26 AM
Unknown Object (File)
Thu, Oct 30, 6:26 AM
Unknown Object (File)
Wed, Oct 29, 9:53 PM
Unknown Object (File)
Wed, Oct 29, 5:37 AM
View All Files
Subscribers
None

Details

Reviewers
kib
jhb
Commits
rS327767: Retire pmtimer driver. Move time fixing into apm driver. Move
Summary

Move time fixing into apm driver. It's still just as broken or working
as it was before, but it's all contained in one place. Move
Iwasaki-san's copyright over.

Test Plan

Leaves just one file that can easily be moved from i386/isa to i386/i386 with conf/files adjusted.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14241
Build 14404: arc lint + arc unit

Event Timeline

imp created this revision.Jan 10 2018, 6:18 AM
imp updated this revision to Diff 37716.Jan 10 2018, 6:22 AM

remove from generic, notes

Harbormaster completed remote builds in B14240: Diff 37716.Jan 10 2018, 6:22 AM
imp updated this revision to Diff 37717.Jan 10 2018, 6:29 AM

Compile it!

Harbormaster completed remote builds in B14241: Diff 37717.Jan 10 2018, 6:29 AM
imp edited the test plan for this revision. (Show Details)Jan 10 2018, 6:34 AM
imp added reviewers: kib, jhb.
imp added inline comments.
sys/i386/bios/apm.c
234

git diff made me do it :) Sorry for all the white-space noise.

1101–1110

So yea, this is ifdef'd out, so this doesn't really do anything.

kib accepted this revision.Jan 10 2018, 8:01 AM
kib added inline comments.
sys/i386/bios/apm.c
1096

Perhaps this and below FIXME could be declared as dead code.

This revision is now accepted and ready to land.Jan 10 2018, 8:01 AM
Closed by commit rS327767: Retire pmtimer driver. Move time fixing into apm driver. Move (authored by imp). · Explain WhyJan 10 2018, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
i386/
bios/
124 lines
conf/
2 lines
2 lines
isa/

Diff 37717

View Options

sys/conf/files.i386

Loading...
View Options

sys/i386/bios/apm.c

Loading...
View Options

sys/i386/conf/GENERIC

Loading...
View Options

sys/i386/conf/NOTES

Loading...
View Options

sys/i386/isa/pmtimer.c

Loading...