games/fretsonfire/Makefile
5	While I agree that the port probably should have been called that when it was created, it wasn't. with your change you'll introduce a, to me at least, annoying discrepancy between the port directory name and the pkg name. Also you don't seem to gain much by doing it, you still need to sed the variable, just at different places.

yuri added inline comments.Jan 9 2018, 6:55 AM

games/fretsonfire/Makefile
5	This `${PORTNAME:S/f/F/g:S/o/O/}` was repeated 5 times! And it is not a nice thing, it's hackish. It became more simple and readable, IMO.

Do you really want to keep ${PORTNAME:S/f/F/g:S/o/O/}?

mat added inline comments.Jan 9 2018, 1:13 PM

games/fretsonfire/Makefile
5	Then simply set some variable to `${PORTNAME:S/f/F/g:S/o/O/}` and use it. Or set a variable to `FretsOnFire` and be done with it.

How important is it to keep the original lowercase PORTNAME?
This is an obscure port, and PORTNAME should have obviously been mixed-case FretsOnFire.
This port is also breaking in build for a very long time.

So, why not just change it now to what it should be, especially that it simplifies things, and also get rid of that ugly hack?

In D13806#290267, @yuri wrote:

How important is it to keep the original lowercase PORTNAME?
This is an obscure port, and PORTNAME should have obviously been mixed-case FretsOnFire.
This port is also breaking in build for a very long time.

So, why not just change it now to what it should be, especially that it simplifies things, and also get rid of that ugly hack?

Well, it's not that important, to me it's just ugly to have the two changes