graphics/py-pyembree: Update to 0.1.2; Unbroke it, it was breaking in configure.
ClosedPublic
Actions

Authored by yuri on Jan 4 2018, 11:53 AM.

Details

Reviewers

tcberner
adamw

Commits

Summary

Simple update.

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 14196
Build 14359: arc lint + arc unit

graphics/py-pyembree/Makefile
21	^ why this change?

graphics/py-pyembree/Makefile
21	why do you keep marking stuff done, without either commenting on it changing it

yuri marked an inline comment as done.Jan 8 2018, 7:20 PM

yuri added inline comments.

graphics/py-pyembree/Makefile
21	Ordered them in the order of use. `distutils` is used first. Actually, I want to change it to `USE_PYTHON=distutils cython autoplist` Following this logic, it should also be `USES=python localbase`, but I've heard people saying that `USES` should be strictly sorted, so it is as it is.
21	But I did update the `USE_PYTHON` line though.

graphics/py-pyembree/Makefile
21	it still changes it, without an explanation "why"

yuri marked 3 inline comments as done.Jan 8 2018, 7:24 PM

yuri added inline comments.

graphics/py-pyembree/Makefile
21	I wrote an explanation "why" :-) Please see a few comments up: `Ordered them in the order of use` Or, perhaps, the phabricator shows you a different set of comments?

graphics/py-pyembree/Makefile
21	Yes, after the fact :) But I don't see any benefit of the change. I would change it if its broken otherwise alphabetizes this just seems like additional noise to me :)

yuri marked 3 inline comments as done.Jan 8 2018, 7:32 PM

yuri added inline comments.

graphics/py-pyembree/Makefile
21	Yes, after the fact :) Actually, I pressed the button on the explanation first, I think. :) this just seems like additional noise to me :) Ok, changed this back.