Page MenuHomeFreeBSD
Differential D13788

units(1) free savescr in error condition too
ClosedPublic
Actions

Authored by eadler on Jan 7 2018, 4:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 22 2024, 4:40 AM
Unknown Object (File)
May 21 2024, 12:20 PM
Unknown Object (File)
May 18 2024, 8:08 AM
Unknown Object (File)
Dec 23 2023, 3:00 AM
Unknown Object (File)
Sep 2 2023, 6:33 AM
Unknown Object (File)
Apr 25 2023, 9:27 AM
Unknown Object (File)
Apr 7 2023, 4:16 PM
Subscribers
des
imp

Details

Reviewers
imp
des
Summary

CID: 978392

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14168
Build 14337: arc lint + arc unit

Event Timeline

eadler created this revision.Jan 7 2018, 4:57 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 7 2018, 4:57 AM
eadler edited the summary of this revision. (Show Details)Jan 7 2018, 4:58 AM
eadler added a reviewer: imp.
des added a subscriber: des.Jan 9 2018, 7:38 AM

You might as well just goto fail.

Also, if you're bored, there are plenty of style bugs in the existing code...

eadler added a comment.Jan 10 2018, 5:30 AM

thought about doing that, but the code ends up looking more confusing at the end. Also tried playing with setting ret var.

des accepted this revision.Jan 12 2018, 12:19 PM
This revision is now accepted and ready to land.Jan 12 2018, 12:19 PM
eadler closed this revision.Jun 18 2018, 2:22 AM

Revision Contents
Changeset List

PathSize
usr.bin/
units/
10 lines

Diff 37601

View Options

usr.bin/units/units.c

Loading...