Page MenuHomeFreeBSD
Differential D13547

Re-added port: textproc/ibus-table: Table-based input method framework for IBus (existed 2009/11/22-2017/04/30, deleted in r439826)
ClosedPublic
Actions

Authored by yuri on Dec 20 2017, 2:27 AM.
Tags
None
Referenced Files
F108360763: D13547.id36787.diff
Fri, Jan 24, 3:51 AM
F108339270: D13547.id36787.diff
Fri, Jan 24, 12:14 AM
Unknown Object (File)
Wed, Jan 22, 11:54 AM
Unknown Object (File)
Wed, Jan 22, 11:54 AM
Unknown Object (File)
Sun, Jan 19, 11:04 PM
Unknown Object (File)
Sun, Jan 19, 11:04 PM
Unknown Object (File)
Sun, Jan 19, 11:04 PM
Unknown Object (File)
Sun, Jan 19, 11:04 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP464755: Re-added port: textproc/ibus-table: Table-based input method framework for IBus…
Summary

Now on GitHub, version 1.9.18

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13664
Build 13884: arc lint + arc unit

Event Timeline

yuri created this revision.Dec 20 2017, 2:27 AM
Herald added a subscriber: mat. · View Herald TranscriptDec 20 2017, 2:27 AM
Harbormaster completed remote builds in B13664: Diff 36786.Dec 20 2017, 2:27 AM
yuri updated this revision to Diff 36787.Dec 20 2017, 2:28 AM

.

Harbormaster completed remote builds in B13665: Diff 36787.Dec 20 2017, 2:28 AM
adamw added a comment.Dec 20 2017, 3:10 AM

Is there a PR associated with this? Does Nikola know you're reviving it? Does he still intend to maintain it?

yuri added a comment.EditedDec 20 2017, 3:30 AM
In D13547#283392, @adamw wrote:

Is there a PR associated with this? Does Nikola know you're reviving it? Does he still intend to maintain it?

I was also thinking if I should have asked him. There is no PR. I will ask him.

mat added inline comments.Dec 20 2017, 8:49 AM
textproc/ibus-table/Makefile
29–35

use options helpers and OPTIONS_SUB.

yuri updated this revision to Diff 36837.Dec 20 2017, 8:52 PM

Used helpers.

Harbormaster completed remote builds in B13700: Diff 36837.Dec 20 2017, 8:52 PM
yuri marked an inline comment as done.Dec 20 2017, 8:53 PM
yuri updated this revision to Diff 36879.Dec 21 2017, 7:56 PM

Nicola Lecic didn't answer, so I take maintainership.

mat added inline comments.Dec 22 2017, 7:50 AM
textproc/ibus-table/pkg-plist
8–11

You have USES=python=3.4+ in the Makefile, but you have 36 hardcoded everywhere in the plist, so I doubt it can build with anything other than Python 3.6 right now.

yuri marked an inline comment as done.Dec 22 2017, 7:54 AM
yuri added inline comments.
textproc/ibus-table/pkg-plist
8–11

Isn't this actually a bug in python ports that __pycache__ gets installed?

yuri marked 2 inline comments as done.Dec 22 2017, 8:03 AM
yuri added inline comments.
textproc/ibus-table/pkg-plist
8–11

Only very few ports have __pycache__ in pkg-plist which makes me think this is a bug.

yuri updated this revision to Diff 36903.Dec 22 2017, 8:08 AM
yuri marked an inline comment as done.

Nuked __pycache__.

Harbormaster completed remote builds in B13742: Diff 36903.Dec 22 2017, 8:08 AM
yuri marked an inline comment as done.Dec 22 2017, 8:08 AM
yuri added a comment.Dec 24 2017, 9:54 PM

Both ibus ports are ready to be reincarnated. The original maintainer wasn't enthusiastic, so I took ownership.

adamw added inline comments.Feb 3 2018, 9:17 PM
textproc/ibus-table/Makefile
15

It's very unusual for a port to actually depend on docbook. Does the port need a DOCS option?

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2018, 5:05 AM
Closed by commit rP464755: Re-added port: textproc/ibus-table: Table-based input method framework for IBus… (authored by yuri). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
textproc/
1 line
25 lines
5 lines
56 lines

Diff 36786

View Options

MOVED

Loading...
View Options

textproc/Makefile

Loading...
View Options

textproc/ibus-table/

Loading...
View Options

textproc/ibus-table/Makefile

Loading...
View Options

textproc/ibus-table/distinfo

Loading...
View Options

textproc/ibus-table/files/

Loading...
View Options

textproc/ibus-table/files/patch-configure

Loading...
View Options

textproc/ibus-table/pkg-plist

Loading...