Page MenuHomeFreeBSD

Use unsigned intptr_t type for framebuffer addresses
ClosedPublic

Authored by jhibbits on Dec 2 2017, 1:48 AM.
Tags
None
Referenced Files
F149538295: D13332.id.diff
Wed, Mar 25, 3:00 AM
F149532107: D13332.id.diff
Wed, Mar 25, 1:51 AM
F149503288: D13332.id36282.diff
Tue, Mar 24, 9:45 PM
F149491425: D13332.id36087.diff
Tue, Mar 24, 7:47 PM
Unknown Object (File)
Sun, Mar 22, 4:14 PM
Unknown Object (File)
Sun, Mar 22, 4:02 AM
Unknown Object (File)
Thu, Mar 19, 4:56 AM
Unknown Object (File)
Wed, Mar 18, 3:39 AM
Subscribers

Details

Summary

Some architectures (powerpc Book-E) have a vm_paddr_t larger than intptr_t.
Casting from the intptr_t to vm_paddr_t causes sign extension, leading to a
potentially invalid address.

This was seen when running X on a PowerPC P1022 machine, which mapped the
backing framebuffer at 0xc1800000. When mmap()d by X, this yielded an invalid
address of 0xffffffffc1800000, or, as the hardware would see it, 0xfc1800000.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable