Page MenuHomeFreeBSD

Use unsigned intptr_t type for framebuffer addresses
ClosedPublic

Authored by jhibbits on Dec 2 2017, 1:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 6:21 PM
Unknown Object (File)
Thu, Nov 20, 6:12 PM
Unknown Object (File)
Thu, Nov 20, 6:12 PM
Unknown Object (File)
Thu, Nov 20, 6:01 PM
Unknown Object (File)
Mon, Nov 10, 1:54 PM
Unknown Object (File)
Mon, Nov 10, 4:37 AM
Unknown Object (File)
Mon, Nov 10, 3:54 AM
Unknown Object (File)
Thu, Nov 6, 4:07 AM
Subscribers

Details

Summary

Some architectures (powerpc Book-E) have a vm_paddr_t larger than intptr_t.
Casting from the intptr_t to vm_paddr_t causes sign extension, leading to a
potentially invalid address.

This was seen when running X on a PowerPC P1022 machine, which mapped the
backing framebuffer at 0xc1800000. When mmap()d by X, this yielded an invalid
address of 0xffffffffc1800000, or, as the hardware would see it, 0xfc1800000.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13258
Build 13495: arc lint + arc unit