Page MenuHomeFreeBSD
Differential D13252

net-im/qTox: Update to 1.13.0
ClosedPublic
Actions

Authored by yuri on Nov 26 2017, 5:56 PM.
Tags
None
Referenced Files
F115230192: D13252.id35808.diff
Mon, Apr 21, 3:52 PM
F115214384: D13252.id35844.diff
Mon, Apr 21, 12:18 PM
Unknown Object (File)
Tue, Apr 15, 12:48 AM
Unknown Object (File)
Mon, Apr 14, 3:35 AM
Unknown Object (File)
Sat, Apr 12, 9:25 PM
Unknown Object (File)
Sat, Apr 12, 3:51 AM
Unknown Object (File)
Mar 16 2025, 1:20 AM
Unknown Object (File)
Feb 28 2025, 4:09 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP455020: net-im/qTox: Update to 1.13.0
Summary

Simple update

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13134
Build 13381: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 26 2017, 5:56 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 26 2017, 5:56 PM
Harbormaster completed remote builds in B13078: Diff 35808.Nov 26 2017, 5:56 PM
tcberner added inline comments.Nov 27 2017, 6:43 AM
net-im/qTox/Makefile
32

^ move qmake_build to the real list. this is not a bug, but just how Qt works [qmake is like llvm-config for llvm and so on.]

yuri updated this revision to Diff 35844.Nov 27 2017, 6:54 AM
yuri marked an inline comment as done.

.

yuri added a comment.Nov 27 2017, 6:54 AM

.

tcberner added inline comments.Nov 27 2017, 9:33 PM
net-im/qTox/Makefile
9

^ you could update the Mailadress

yuri updated this revision to Diff 35903.Nov 28 2017, 3:10 AM

.

Harbormaster completed remote builds in B13134: Diff 35903.Nov 28 2017, 3:10 AM
yuri marked an inline comment as done.Nov 28 2017, 3:10 AM
tcberner accepted this revision.Nov 28 2017, 6:11 AM
This revision is now accepted and ready to land.Nov 28 2017, 6:11 AM
Closed by commit rP455020: net-im/qTox: Update to 1.13.0 (authored by yuri). · Explain WhyNov 28 2017, 6:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
net-im/
qTox/
42 lines
6 lines

Diff 35903

View Options

net-im/qTox/Makefile

Show All 28 Lines
.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF .\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
.\" THIS SOFTWARE, EVEN IF WHISTLE COMMUNICATIONS IS ADVISED OF THE POSSIBILITY .\" THIS SOFTWARE, EVEN IF WHISTLE COMMUNICATIONS IS ADVISED OF THE POSSIBILITY
.\" OF SUCH DAMAGE. .\" OF SUCH DAMAGE.
.\" .\"
.\" Author: Archie Cobbs <archie@FreeBSD.org> .\" Author: Archie Cobbs <archie@FreeBSD.org>
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd October 2, 2019 .Dd April 29, 2020
.Dt NG_BRIDGE 4 .Dt NG_BRIDGE 4
.Os .Os
.Sh NAME .Sh NAME
.Nm ng_bridge .Nm ng_bridge
.Nd Ethernet bridging netgraph node type .Nd Ethernet bridging netgraph node type
.Sh SYNOPSIS .Sh SYNOPSIS
.In sys/types.h .In sys/types.h
.In netgraph/ng_bridge.h .In netgraph/ng_bridge.h
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
hooks of one or more hooks of one or more
.Xr ng_ether 4 .Xr ng_ether 4
nodes. nodes.
To connect the host machine to a bridged network, simply connect the To connect the host machine to a bridged network, simply connect the
.Dv upper .Dv upper
hook of an hook of an
.Xr ng_ether 4 .Xr ng_ether 4
node to the bridge node. node to the bridge node.
.Pp
Instead of naming a hook
.Dv linkX
the hook might be also named
.Dv uplinkX .
The node does not learn MAC addresses on uplink hooks, which keeps
dabUnsubmitted
Done
Inline Actions

s/does no/does not/

dab: s/does no/does not/
the internal address table small.
bcrUnsubmitted
Done
Inline Actions

You need to make a line break after a sentence stop.

bcr: You need to make a line break after a sentence stop.
dabUnsubmitted
Done
Inline Actions

I don't think it is common usage to start a sentence with "i.e.", nor is it common usage to capitalize such an abbreviation. Such an abbreviation is usually followed by a comma. Suggest:

the internal address table small; i.e., it's desirable to connect

That would also address the newline after full stop issue. :-)

dab: I don't think it is common usage to start a sentence with "i.e.", nor is it common usage to…
danfeUnsubmitted
Done
Inline Actions

Apart from the above (line break, comma after i.e.), contraction should be expanded: it's -> it is.

danfe: Apart from the above (line break, comma after i.e.), contraction should be expanded: //it's//…
This way it is desirable to connect the
.Dv lower
hook of an
.Xr ng_ether 4
node to an
.Dv uplink
dabUnsubmitted
Done
Inline Actions

s/send out/sent out/

dab: s/send out/sent out/
hook of the bridge, and ignore the complexity of the outside world.
Frames with unknown MACs are always sent out to
.Dv uplink
hooks, so no functionality is lost.
.Sh CONTROL MESSAGES .Sh CONTROL MESSAGES
This node type supports the generic control messages, plus the This node type supports the generic control messages, plus the
following: following:
.Bl -tag -width foo .Bl -tag -width foo
.It Dv NGM_BRIDGE_SET_CONFIG Pq Ic setconfig .It Dv NGM_BRIDGE_SET_CONFIG Pq Ic setconfig
Set the node configuration. Set the node configuration.
This command takes a This command takes a
.Dv "struct ng_bridge_config" .Dv "struct ng_bridge_config"
Show All 32 Lines
Returns the current configuration as a Returns the current configuration as a
.Dv "struct ng_bridge_config" . .Dv "struct ng_bridge_config" .
.It Dv NGM_BRIDGE_RESET Pq Ic reset .It Dv NGM_BRIDGE_RESET Pq Ic reset
Causes the node to forget all hosts and unmute all links. Causes the node to forget all hosts and unmute all links.
The node configuration is not changed. The node configuration is not changed.
.It Dv NGM_BRIDGE_GET_STATS Pq Ic getstats .It Dv NGM_BRIDGE_GET_STATS Pq Ic getstats
This command takes a four byte link number as an argument and This command takes a four byte link number as an argument and
returns a returns a
.Dv "struct ng_bridge_link_stats" .Dv "struct ng_bridge_link_stats"
containing statistics for the corresponding link, which must be containing statistics for the corresponding
yuripvUnsubmitted
Done
Inline Actions

just a note as .Dv seems to be misused throughout this entire man page -- .Dv does not seem to be the correct choice for struct ng_bridge_link_stats, use .Vt? and for link, may be .Va?

yuripv: just a note as `.Dv` seems to be misused throughout this entire man page -- `.Dv` does not seem…
donnerAuthorUnsubmitted
Done
Inline Actions

I'd like to keep it consistent for the moment and fix this issue in a separate review.

donner: I'd like to keep it consistent for the moment and fix this issue in a separate review.
currently connected: .Dv link ,
which must be currently connected:
.Bd -literal -offset 0n .Bd -literal -offset 0n
/* Statistics structure (one for each link) */ /* Statistics structure (one for each link) */
struct ng_bridge_link_stats { struct ng_bridge_link_stats {
uint64_t recvOctets; /* total octets rec'd on link */ uint64_t recvOctets; /* total octets rec'd on link */
uint64_t recvPackets; /* total pkts rec'd on link */ uint64_t recvPackets; /* total pkts rec'd on link */
uint64_t recvMulticasts; /* multicast pkts rec'd on link */ uint64_t recvMulticasts; /* multicast pkts rec'd on link */
uint64_t recvBroadcasts; /* broadcast pkts rec'd on link */ uint64_t recvBroadcasts; /* broadcast pkts rec'd on link */
uint64_t recvUnknown; /* pkts rec'd with unknown dest addr */ uint64_t recvUnknown; /* pkts rec'd with unknown dest addr */
uint64_t recvRunts; /* pkts rec'd less than 14 bytes */ uint64_t recvRunts; /* pkts rec'd less than 14 bytes */
uint64_t recvInvalid; /* pkts rec'd with bogus source addr */ uint64_t recvInvalid; /* pkts rec'd with bogus source addr */
uint64_t xmitOctets; /* total octets xmit'd on link */ uint64_t xmitOctets; /* total octets xmit'd on link */
uint64_t xmitPackets; /* total pkts xmit'd on link */ uint64_t xmitPackets; /* total pkts xmit'd on link */
uint64_t xmitMulticasts; /* multicast pkts xmit'd on link */ uint64_t xmitMulticasts; /* multicast pkts xmit'd on link */
uint64_t xmitBroadcasts; /* broadcast pkts xmit'd on link */ uint64_t xmitBroadcasts; /* broadcast pkts xmit'd on link */
uint64_t loopDrops; /* pkts dropped due to loopback */ uint64_t loopDrops; /* pkts dropped due to loopback */
uint64_t loopDetects; /* number of loop detections */ uint64_t loopDetects; /* number of loop detections */
uint64_t memoryFailures; /* times couldn't get mem or mbuf */ uint64_t memoryFailures; /* times couldn't get mem or mbuf */
}; };
.Ed .Ed
.Pp
Negative numbers refer to the
.Dv uplink
hooks.
So querying for -7 will get the statistics for hook
dabUnsubmitted
Done
Inline Actions

s/quering/querying/

dab: s/quering/querying/
.Dv uplink7 .
.It Dv NGM_BRIDGE_CLR_STATS Pq Ic clrstats .It Dv NGM_BRIDGE_CLR_STATS Pq Ic clrstats
This command takes a four byte link number as an argument and This command takes a four byte link number as an argument and
clears the statistics for that link. clears the statistics for that link.
.It Dv NGM_BRIDGE_GETCLR_STATS Pq Ic getclrstats .It Dv NGM_BRIDGE_GETCLR_STATS Pq Ic getclrstats
Same as Same as
.Dv NGM_BRIDGE_GET_STATS , .Dv NGM_BRIDGE_GET_STATS ,
but also atomically clears the statistics as well. but also atomically clears the statistics as well.
.It Dv NGM_BRIDGE_GET_TABLE Pq Ic gettable .It Dv NGM_BRIDGE_GET_TABLE Pq Ic gettable
Show All 32 Lines
View Options

net-im/qTox/distinfo

Show All 28 Lines
.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF .\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
.\" THIS SOFTWARE, EVEN IF WHISTLE COMMUNICATIONS IS ADVISED OF THE POSSIBILITY .\" THIS SOFTWARE, EVEN IF WHISTLE COMMUNICATIONS IS ADVISED OF THE POSSIBILITY
.\" OF SUCH DAMAGE. .\" OF SUCH DAMAGE.
.\" .\"
.\" Author: Archie Cobbs <archie@FreeBSD.org> .\" Author: Archie Cobbs <archie@FreeBSD.org>
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd October 2, 2019 .Dd April 29, 2020
.Dt NG_BRIDGE 4 .Dt NG_BRIDGE 4
.Os .Os
.Sh NAME .Sh NAME
.Nm ng_bridge .Nm ng_bridge
.Nd Ethernet bridging netgraph node type .Nd Ethernet bridging netgraph node type
.Sh SYNOPSIS .Sh SYNOPSIS
.In sys/types.h .In sys/types.h
.In netgraph/ng_bridge.h .In netgraph/ng_bridge.h
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
hooks of one or more hooks of one or more
.Xr ng_ether 4 .Xr ng_ether 4
nodes. nodes.
To connect the host machine to a bridged network, simply connect the To connect the host machine to a bridged network, simply connect the
.Dv upper .Dv upper
hook of an hook of an
.Xr ng_ether 4 .Xr ng_ether 4
node to the bridge node. node to the bridge node.
.Pp
Instead of naming a hook
.Dv linkX
the hook might be also named
.Dv uplinkX .
The node does not learn MAC addresses on uplink hooks, which keeps
dabUnsubmitted
Done
Inline Actions

s/does no/does not/

dab: s/does no/does not/
the internal address table small.
bcrUnsubmitted
Done
Inline Actions

You need to make a line break after a sentence stop.

bcr: You need to make a line break after a sentence stop.
dabUnsubmitted
Done
Inline Actions

I don't think it is common usage to start a sentence with "i.e.", nor is it common usage to capitalize such an abbreviation. Such an abbreviation is usually followed by a comma. Suggest:

the internal address table small; i.e., it's desirable to connect

That would also address the newline after full stop issue. :-)

dab: I don't think it is common usage to start a sentence with "i.e.", nor is it common usage to…
danfeUnsubmitted
Done
Inline Actions

Apart from the above (line break, comma after i.e.), contraction should be expanded: it's -> it is.

danfe: Apart from the above (line break, comma after i.e.), contraction should be expanded: //it's//…
This way it is desirable to connect the
.Dv lower
hook of an
.Xr ng_ether 4
node to an
.Dv uplink
dabUnsubmitted
Done
Inline Actions

s/send out/sent out/

dab: s/send out/sent out/
hook of the bridge, and ignore the complexity of the outside world.
Frames with unknown MACs are always sent out to
.Dv uplink
hooks, so no functionality is lost.
.Sh CONTROL MESSAGES .Sh CONTROL MESSAGES
This node type supports the generic control messages, plus the This node type supports the generic control messages, plus the
following: following:
.Bl -tag -width foo .Bl -tag -width foo
.It Dv NGM_BRIDGE_SET_CONFIG Pq Ic setconfig .It Dv NGM_BRIDGE_SET_CONFIG Pq Ic setconfig
Set the node configuration. Set the node configuration.
This command takes a This command takes a
.Dv "struct ng_bridge_config" .Dv "struct ng_bridge_config"
Show All 32 Lines
Returns the current configuration as a Returns the current configuration as a
.Dv "struct ng_bridge_config" . .Dv "struct ng_bridge_config" .
.It Dv NGM_BRIDGE_RESET Pq Ic reset .It Dv NGM_BRIDGE_RESET Pq Ic reset
Causes the node to forget all hosts and unmute all links. Causes the node to forget all hosts and unmute all links.
The node configuration is not changed. The node configuration is not changed.
.It Dv NGM_BRIDGE_GET_STATS Pq Ic getstats .It Dv NGM_BRIDGE_GET_STATS Pq Ic getstats
This command takes a four byte link number as an argument and This command takes a four byte link number as an argument and
returns a returns a
.Dv "struct ng_bridge_link_stats" .Dv "struct ng_bridge_link_stats"
containing statistics for the corresponding link, which must be containing statistics for the corresponding
yuripvUnsubmitted
Done
Inline Actions

just a note as .Dv seems to be misused throughout this entire man page -- .Dv does not seem to be the correct choice for struct ng_bridge_link_stats, use .Vt? and for link, may be .Va?

yuripv: just a note as `.Dv` seems to be misused throughout this entire man page -- `.Dv` does not seem…
donnerAuthorUnsubmitted
Done
Inline Actions

I'd like to keep it consistent for the moment and fix this issue in a separate review.

donner: I'd like to keep it consistent for the moment and fix this issue in a separate review.
currently connected: .Dv link ,
which must be currently connected:
.Bd -literal -offset 0n .Bd -literal -offset 0n
/* Statistics structure (one for each link) */ /* Statistics structure (one for each link) */
struct ng_bridge_link_stats { struct ng_bridge_link_stats {
uint64_t recvOctets; /* total octets rec'd on link */ uint64_t recvOctets; /* total octets rec'd on link */
uint64_t recvPackets; /* total pkts rec'd on link */ uint64_t recvPackets; /* total pkts rec'd on link */
uint64_t recvMulticasts; /* multicast pkts rec'd on link */ uint64_t recvMulticasts; /* multicast pkts rec'd on link */
uint64_t recvBroadcasts; /* broadcast pkts rec'd on link */ uint64_t recvBroadcasts; /* broadcast pkts rec'd on link */
uint64_t recvUnknown; /* pkts rec'd with unknown dest addr */ uint64_t recvUnknown; /* pkts rec'd with unknown dest addr */
uint64_t recvRunts; /* pkts rec'd less than 14 bytes */ uint64_t recvRunts; /* pkts rec'd less than 14 bytes */
uint64_t recvInvalid; /* pkts rec'd with bogus source addr */ uint64_t recvInvalid; /* pkts rec'd with bogus source addr */
uint64_t xmitOctets; /* total octets xmit'd on link */ uint64_t xmitOctets; /* total octets xmit'd on link */
uint64_t xmitPackets; /* total pkts xmit'd on link */ uint64_t xmitPackets; /* total pkts xmit'd on link */
uint64_t xmitMulticasts; /* multicast pkts xmit'd on link */ uint64_t xmitMulticasts; /* multicast pkts xmit'd on link */
uint64_t xmitBroadcasts; /* broadcast pkts xmit'd on link */ uint64_t xmitBroadcasts; /* broadcast pkts xmit'd on link */
uint64_t loopDrops; /* pkts dropped due to loopback */ uint64_t loopDrops; /* pkts dropped due to loopback */
uint64_t loopDetects; /* number of loop detections */ uint64_t loopDetects; /* number of loop detections */
uint64_t memoryFailures; /* times couldn't get mem or mbuf */ uint64_t memoryFailures; /* times couldn't get mem or mbuf */
}; };
.Ed .Ed
.Pp
Negative numbers refer to the
.Dv uplink
hooks.
So querying for -7 will get the statistics for hook
dabUnsubmitted
Done
Inline Actions

s/quering/querying/

dab: s/quering/querying/
.Dv uplink7 .
.It Dv NGM_BRIDGE_CLR_STATS Pq Ic clrstats .It Dv NGM_BRIDGE_CLR_STATS Pq Ic clrstats
This command takes a four byte link number as an argument and This command takes a four byte link number as an argument and
clears the statistics for that link. clears the statistics for that link.
.It Dv NGM_BRIDGE_GETCLR_STATS Pq Ic getclrstats .It Dv NGM_BRIDGE_GETCLR_STATS Pq Ic getclrstats
Same as Same as
.Dv NGM_BRIDGE_GET_STATS , .Dv NGM_BRIDGE_GET_STATS ,
but also atomically clears the statistics as well. but also atomically clears the statistics as well.
.It Dv NGM_BRIDGE_GET_TABLE Pq Ic gettable .It Dv NGM_BRIDGE_GET_TABLE Pq Ic gettable
Show All 32 Lines