Page MenuHomeFreeBSD
Differential D12424

Add basic tests for chflags(1), ctfconvert(1), fold(1) and rs(1)
ClosedPublic
Actions

Authored by shivansh on Sep 20 2017, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 11:27 AM
Unknown Object (File)
Nov 16 2024, 5:06 AM
Unknown Object (File)
Oct 5 2024, 3:51 PM
Unknown Object (File)
Oct 5 2024, 7:28 AM
Unknown Object (File)
Oct 2 2024, 2:21 PM
Unknown Object (File)
Oct 2 2024, 7:19 AM
Unknown Object (File)
Oct 2 2024, 4:40 AM
Unknown Object (File)
Oct 2 2024, 1:20 AM
View All 67 Files
Subscribers
None

Details

Reviewers
asomers
brooks
ngie
Commits
rS327186: MFC r326289:
rS326289: Add basic tests for ctfconvert(1), fold(1) and rs(1)
Summary

Tests generated via: https://github.com/shivansh/smoketestsuite/
Reference: r323275

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13056
Build 13307: arc lint + arc unit

Event Timeline

shivansh created this revision.Sep 20 2017, 4:27 PM
Harbormaster completed remote builds in B11640: Diff 33241.Sep 20 2017, 4:27 PM
asomers requested changes to this revision.Sep 21 2017, 3:13 PM

It is not ok to impose restrictions on how somebody invokes "kyua test". If some of these tests need to close stdin, then you'll have to do that from within the testcase body.

This revision now requires changes to proceed.Sep 21 2017, 3:13 PM
shivansh updated this revision to Diff 33267.Sep 21 2017, 3:39 PM

Close stdin where required in the tests

shivansh edited the summary of this revision. (Show Details)Sep 21 2017, 3:40 PM
asomers added a comment.Oct 4 2017, 3:21 PM

Can you please add .include <src.opts.mk> to every Makefile that references MK_TESTS?

shivansh updated this revision to Diff 33695.Oct 4 2017, 3:51 PM

Add .include <src.opts.mk> to every Makefile that references MK_TESTS

asomers accepted this revision.Oct 9 2017, 9:39 PM
This revision is now accepted and ready to land.Oct 9 2017, 9:39 PM
asomers requested changes to this revision.Oct 9 2017, 10:46 PM

I just realized that this review is out of date. chflags' tests were already submitted in r323275 on 7-sep. Could you please update the review to either remove chflags or, if the chflags tests are changing, rebase the changes on top of head?

This revision now requires changes to proceed.Oct 9 2017, 10:46 PM
shivansh updated this revision to Diff 35772.Nov 25 2017, 7:38 PM

Remove test for chflags(1) -- already submitted in r323275.

PS. My apologies for the delay, just finished with my final exams today!

asomers accepted this revision.Nov 27 2017, 6:33 PM

LGTM.

This revision is now accepted and ready to land.Nov 27 2017, 6:33 PM
Closed by commit rS326289: Add basic tests for ctfconvert(1), fold(1) and rs(1) (authored by asomers). · Explain WhyNov 27 2017, 8:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cddl/
usr.bin/
ctfconvert/
5 lines
tests/
5 lines
62 lines
etc/
mtree/
6 lines
usr.bin/
fold/
5 lines
tests/
5 lines
81 lines
rs/
5 lines
tests/
5 lines
278 lines

Diff 35772

View Options

cddl/usr.bin/ctfconvert/Makefile

Loading...
View Options

cddl/usr.bin/ctfconvert/tests/Makefile

Loading...
View Options

cddl/usr.bin/ctfconvert/tests/ctfconvert_test.sh

Loading...
View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.bin/fold/Makefile

Loading...
View Options

usr.bin/fold/tests/Makefile

Loading...
View Options

usr.bin/fold/tests/fold_test.sh

Loading...
View Options

usr.bin/rs/Makefile

Loading...
View Options

usr.bin/rs/tests/Makefile

Loading...
View Options

usr.bin/rs/tests/rs_test.sh

Loading...