Page MenuHomeFreeBSD
Differential D13216

New port: science/mcxtrace: Monte Carlo X-ray tracing package
ClosedPublic
Actions

Authored by yuri on Nov 23 2017, 10:29 PM.
Tags
None
Referenced Files
F133629062: D13216.diff
Mon, Oct 27, 3:28 AM
Unknown Object (File)
Fri, Oct 24, 4:59 AM
Unknown Object (File)
Wed, Oct 15, 4:29 AM
Unknown Object (File)
Sun, Oct 5, 8:32 AM
Unknown Object (File)
Sat, Oct 4, 1:44 AM
Unknown Object (File)
Sat, Oct 4, 1:16 AM
Unknown Object (File)
Thu, Oct 2, 6:22 AM
Unknown Object (File)
Thu, Oct 2, 4:38 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
mat
Commits
rP455608: New port: science/mcxtrace: Monte Carlo X-ray tracing package
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206505

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12984
Build 13239: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 23 2017, 10:29 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 23 2017, 10:29 PM
Harbormaster completed remote builds in B12984: Diff 35672.Nov 23 2017, 10:29 PM
mat added inline comments.Nov 24 2017, 6:23 PM
science/mcxtrace/Makefile
22–25

If the man pages do not need some extra dependency to be built, they must always be installed, without any option.

mat requested changes to this revision.Nov 24 2017, 6:24 PM
This revision now requires changes to proceed.Nov 24 2017, 6:24 PM
yuri updated this revision to Diff 35713.Nov 24 2017, 7:20 PM

Removed the MANOPAGES option.

Harbormaster completed remote builds in B13012: Diff 35713.Nov 24 2017, 7:20 PM
tcberner added inline comments.Nov 24 2017, 7:48 PM
science/mcxtrace/pkg-plist
13

^ why are the c-files installed too?

yuri marked 2 inline comments as done.Nov 24 2017, 7:59 PM
yuri added inline comments.
science/mcxtrace/pkg-plist
13

I forwarded this question to the original submitter.

yuri marked 2 inline comments as done.Nov 24 2017, 7:59 PM
yuri added inline comments.Nov 24 2017, 8:57 PM
science/mcxtrace/pkg-plist
13

The original submitted confirmed that .c/.h are indeed needed due to the way how the program works.

yuri marked an inline comment as done.Nov 24 2017, 8:57 PM
tcberner accepted this revision.Nov 24 2017, 10:29 PM

That is one weird program then :D

tcberner added a comment.Nov 24 2017, 10:29 PM

Remember, that you still need the ok of the other persons here =)

yuri added a comment.Nov 24 2017, 10:34 PM
In D13216#275842, @tcberner wrote:

Remember, that you still need the ok of the other persons here =)

Ok!

yuri added a comment.Nov 25 2017, 8:58 PM

This is ready.
These .c/.h files are need for it to run.

mat accepted this revision.Nov 27 2017, 1:31 PM

ok for me.

This revision is now accepted and ready to land.Nov 27 2017, 1:31 PM
mat added inline comments.Nov 27 2017, 1:31 PM
science/mcxtrace/Makefile
25

This should be using ${RLN} instead.

yuri updated this revision to Diff 35864.Nov 27 2017, 5:22 PM

Replaced LN -> RLN

This revision now requires review to proceed.Nov 27 2017, 5:22 PM
Harbormaster completed remote builds in B13109: Diff 35864.Nov 27 2017, 5:22 PM
yuri marked an inline comment as done.Nov 27 2017, 5:23 PM
tcberner added a comment.Dec 5 2017, 7:01 PM

@yuri, every one accepted this :)

Closed by commit rP455608: New port: science/mcxtrace: Monte Carlo X-ray tracing package (authored by yuri). · Explain WhyDec 5 2017, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35672

View Options

science/Makefile

Loading...
View Options

science/mcxtrace/

Loading...
View Options

science/mcxtrace/Makefile

Loading...
View Options

science/mcxtrace/distinfo

Loading...
View Options

science/mcxtrace/files/

Loading...
View Options

science/mcxtrace/files/patch-cmake_Modules_InstallMCCODE.cmake

Loading...
View Options

science/mcxtrace/pkg-descr

Loading...
View Options

science/mcxtrace/pkg-plist

Loading...