Page MenuHomeFreeBSD
Differential D13165

New port: x11/xcape: Configure modifier keys to act as other keys when pressed on their own
ClosedPublic
Actions

Authored by yuri on Nov 20 2017, 3:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 2, 7:13 AM
Unknown Object (File)
Wed, Aug 26, 5:18 PM
Unknown Object (File)
Wed, Aug 26, 5:16 PM
Unknown Object (File)
Wed, Aug 26, 5:10 PM
Unknown Object (File)
Wed, Aug 12, 3:22 AM
Unknown Object (File)
Sat, Aug 8, 5:34 PM
Unknown Object (File)
Jul 27 2026, 3:49 PM
Unknown Object (File)
Jul 18 2026, 10:59 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP454853: New port: x11/xcape: Configure modifier keys to act as other keys when pressed…
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222602

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12881
Build 13143: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 20 2017, 3:20 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 20 2017, 3:20 AM
Harbormaster completed remote builds in B12881: Diff 35485.Nov 20 2017, 3:20 AM
tcberner added inline comments.Nov 22 2017, 6:02 AM
x11/xcape/Makefile
21

^ this looks unecessary/wrong

yuri marked an inline comment as done.Nov 22 2017, 6:12 AM
yuri added inline comments.
x11/xcape/Makefile
21

Why do you think this is wrong? This makefile has =, not >=. GNU make has the feature that it still sets such variables (with =) when they are placed into make's arguments, but not into its environment.

This line exploits this feature. Do you think it's wrong?

yuri marked 2 inline comments as done.Nov 22 2017, 6:12 AM
tcberner added inline comments.Nov 22 2017, 6:22 AM
x11/xcape/Makefile
21

MANDIR sounded absolute, and PREFIX unessessary :) looking at the Makefile, you're right.

yuri marked an inline comment as done.Nov 22 2017, 6:31 AM
yuri added inline comments.Nov 22 2017, 6:49 AM
x11/xcape/Makefile
21

So, approved?

yuri marked an inline comment as done.Nov 22 2017, 6:49 AM
yuri added a comment.Nov 23 2017, 6:44 AM
This comment was removed by yuri.
tcberner accepted this revision.Nov 24 2017, 9:54 PM

indeed

This revision is now accepted and ready to land.Nov 24 2017, 9:54 PM
Closed by commit rP454853: New port: x11/xcape: Configure modifier keys to act as other keys when pressed… (authored by yuri). · Explain WhyNov 24 2017, 10:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
x11/
1 line
28 lines
3 lines
5 lines

Diff 35485

View Options

x11/Makefile

Loading...
View Options

x11/xcape/

Loading...
View Options

x11/xcape/Makefile

Loading...
View Options

x11/xcape/distinfo

Loading...
View Options

x11/xcape/pkg-descr

Loading...