Paths

Table of Contentst

devel/libfmt: Update: Added LICENSE_FILE; Added BUILD_SHARED_LIBS=ON
ClosedPublic
Actions

Authored by yuri on Nov 6 2017, 10:03 PM.

Details

Reviewers

tcberner
adamw

Commits

rP453704: devel/libfmt: Update: Added LICENSE_FILE; Added BUILD_SHARED_LIBS=ON

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223451

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 12534
Build 12809: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 6 2017, 10:03 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 6 2017, 10:03 PM

Harbormaster completed remote builds in B12521: Diff 34865.Nov 7 2017, 3:51 PM

mat added inline comments.Nov 7 2017, 4:51 PM

devel/libfmt/Makefile
5	Try not to change this when the version itself does not change, to avoid too much churn in the repository.

No DISTVERSION when version didn't change.

Harbormaster completed remote builds in B12534: Diff 34887.Nov 7 2017, 5:11 PM

tcberner added inline comments.Nov 7 2017, 8:45 PM

devel/libfmt/Makefile
21	^ maybe think about using `TEST_CMAKE_BOOL= FMT_TEST`

Requested changes.

Harbormaster completed remote builds in B12545: Diff 34899.Nov 7 2017, 9:10 PM

yuri added inline comments.Nov 7 2017, 9:10 PM

devel/libfmt/Makefile
21	This was a preexisting line :)

tcberner accepted this revision.Nov 7 2017, 9:35 PM

tcberner added inline comments.

devel/libfmt/Makefile
18	^ USES should appear befor any USE_FOO
21	^^ Now it isn't :D

This revision is now accepted and ready to land.Nov 7 2017, 9:35 PM

yuri marked 3 inline comments as done.Nov 7 2017, 9:44 PM

yuri closed this revision.Nov 7 2017, 9:47 PM

Revision Contents
Changeset List

Path

Size

devel/

libfmt/

Makefile

6 lines

pkg-plist

4 lines

Diff 34887

View Options

devel/libfmt/Makefile