Page MenuHomeFreeBSD
Differential D12942

devel/py-python-gist: Update to 0.5.3.
ClosedPublic
Actions

Authored by yuri on Nov 4 2017, 2:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 16, 2:28 AM
Unknown Object (File)
Thu, Nov 13, 12:33 PM
Unknown Object (File)
Sun, Nov 2, 1:40 AM
Unknown Object (File)
Fri, Oct 31, 10:27 PM
Unknown Object (File)
Fri, Oct 31, 6:02 PM
Unknown Object (File)
Fri, Oct 31, 6:02 PM
Unknown Object (File)
Fri, Oct 31, 6:02 PM
Unknown Object (File)
Fri, Oct 31, 6:02 PM
View All 80 Files
Subscribers
dbaio
mat

Details

Reviewers
tcberner
adamw
Commits
rP453484: devel/py-python-gist: Update to 0.5.3
Summary

devel/py-python-gist: Update to 0.5.3

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12466
Build 12741: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 4 2017, 2:59 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 4 2017, 2:59 PM
Harbormaster completed remote builds in B12441: Diff 34752.Nov 4 2017, 3:00 PM
yuri added a reviewer: adamw.Nov 4 2017, 3:01 PM
dbaio added a subscriber: dbaio.Nov 4 2017, 3:57 PM
dbaio added inline comments.
devel/py-python-gist/Makefile
25–26

Why not just USES= python ?

yuri marked an inline comment as done.Nov 4 2017, 4:03 PM
yuri added inline comments.
devel/py-python-gist/Makefile
25–26

Because setup.py says that they support these versions. In case python-3.7 comes out, it shouldn't be automatically supported unless they say so.

dbaio added inline comments.Nov 4 2017, 4:34 PM
devel/py-python-gist/Makefile
25–26

That's normal, many packages don't even mention Python 3.6 but they support it, in this case a user found a problem with 3.6 and that's why it was updated (setup.py classifiers and the real fix).
IMHO you can give the benefit of the doubt:

  • user finds a problem with Python 3.7
  • user report it
  • upstream fixes.
yuri updated this revision to Diff 34763.Nov 4 2017, 4:41 PM
yuri marked an inline comment as done.

Updated to USES=python

Harbormaster completed remote builds in B12448: Diff 34763.Nov 4 2017, 4:41 PM
yuri marked an inline comment as done.Nov 4 2017, 4:41 PM
tcberner added inline comments.Nov 4 2017, 8:01 PM
devel/py-python-gist/Makefile
25–26

This should be moved upwards. USES should come before any USE_FOO

yuri updated this revision to Diff 34788.Nov 4 2017, 8:06 PM

Reordered USE_xxx.

Harbormaster completed remote builds in B12466: Diff 34788.Nov 4 2017, 8:06 PM
tcberner accepted this revision.Nov 4 2017, 8:29 PM

Looks good to me.

This revision is now accepted and ready to land.Nov 4 2017, 8:29 PM
Closed by commit rP453484: devel/py-python-gist: Update to 0.5.3 (authored by yuri). · Explain WhyNov 4 2017, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
py-python-gist/
8 lines
6 lines

Diff 34788

View Options

devel/py-python-gist/Makefile

Loading...
View Options

devel/py-python-gist/distinfo

Loading...