www/youtube_dl: update to 2015.01.25
ClosedPublic
Actions

Authored by jbeich on Jan 28 2015, 4:14 AM.

Details

Reviewers

sunpoet
bapt
araujo

Summary

Update to upstream version 2015.01.25 [1][2]
Install FISH and ZSH completions [3]
Mark as NO_ARCH [4]
Remove BASH_DESC now that it's in bsd.options.desc.mk [3]

PR: 196298 [1]
PR: 196946 [2]
PR: 195399 [3]
PR: 195400 [4]
Submitted by: gblach [1], sunpoet [2]
nReviewed by: sunpoet (mainly [3] and [4])
Approved by: araujo (maintainer timeout, 1 month)
Approved by: bapt (mentor)

WARNING: [3] and [4] timed out for ~2 months, [1] for ~1 month and [2] is almost 2 weeks. In the recent past @sunpoet landed a few changes that're not updates per timeout, so he can probably review [3] and [4] as well.

NOTE: Maybe updated again as upstream releases frequently.

Test Plan

poudriere testport logs:
http://slexy.org/view/s2kJ0hVWSw (8.4R amd64)
http://slexy.org/view/s203tQAEiV (10.1R i386)
http://slexy.org/view/s28oapfJ6W (9.3R i386, inverted options)

Runtime test with:

$ youtube-dl --max-<TAB> # zsh
--max-downloads  --max-filesize   --max-quality    --max-views
$ youtube-dl -x GnBbhXBDmwU
$ mpv --ytdl 'https://www.youtube.com/watch?v=GnBbhXBDmwU'

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

jbeich updated this revision to Diff 3468.Jan 28 2015, 4:14 AM

jbeich retitled this revision from to www/youtube_dl: update to 2015.01.25.

jbeich updated this object.

jbeich edited the test plan for this revision. (Show Details)

jbeich added reviewers: araujo, bapt, sunpoet.

jbeich added subscribers: gblach, sunpoet.

Seems good to me. And has my approve.

Sorry my absence recently, but I'm working on some kernel stuff and also heading to get married. Very busy!

Best Regards,

This revision is now accepted and ready to land.Jan 28 2015, 4:19 AM

No need to wait on @sunpoet review

@araujo Congratulation!

www/youtube_dl/Makefile
55	FYI the condition here can safely be removed as pkg will only install in the system what is in the plist hence ignore leave those files in the stage In this particular case it is consistent with the rest of the port so keep them :) In the futur that would be nice to see them go as it will allow to remove the inclusion of bsd.port.options.mk :)

@bapt Thank you very much!!!

Closed by commit rP378059 (authored by @jbeich).

www/youtube_dl/Makefile

Currently, removing conditionals wouldn't make poudriere testport happy.

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: etc/bash_completion.d/youtube-dl.sh
Error: Orphaned: share/fish/completions/youtube-dl.fish
Error: Orphaned: share/zsh/site-functions/_youtube-dl
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.