Page MenuHomeFreeBSD
Differential D12833

EPSON RTC-8583 support code on i2c bus
ClosedPublic
Actions

Authored by yamori813_yahoo.co.jp on Oct 30 2017, 8:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 12, 9:42 AM
Unknown Object (File)
Mon, Jul 7, 4:10 AM
Unknown Object (File)
Fri, Jul 4, 12:39 PM
Unknown Object (File)
Thu, Jul 3, 5:26 AM
Unknown Object (File)
Mon, Jun 23, 10:12 PM
Unknown Object (File)
Mon, Jun 23, 2:15 AM
Unknown Object (File)
Fri, Jun 20, 10:05 PM
Unknown Object (File)
Fri, Jun 20, 1:25 PM
View All 80 Files
Subscribers
None

Details

Reviewers
• ian
mizhka
adrian
gonzo
loos
Commits
rS331503: MFC r325233, r328956, r329170, r329172-r329173, r329224, r330403-r330407,
rS325233: [i2c/clock] add support for EPSON RTC-8583
Summary

This is start up log.

https://gist.github.com/yamori813/bd6ccdbd73dd02eebfdd0bd6d92411d8

Test Plan

on RT2880 (Planex_MZK-W300NAG)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yamori813_yahoo.co.jp created this revision.Oct 30 2017, 8:28 AM
yamori813_yahoo.co.jp added a comment.EditedOct 30 2017, 8:30 AM

This is dts

&i2c {
        status = "okay";
        rtc8583 {
                status = "okay";
                compatible = "epson,rtc8583";
                reg = <0x50>;
        };
};
mizhka accepted this revision.Oct 30 2017, 1:16 PM

Few cosmetic style issues...

sys/dev/iicbus/rtc8583.c
183–200 ↗(On Diff #34449)

I see datasheet for this clock, but can't understand this algo :)
ftp://download.epson-europe.com/pub/electronics-de/quartz/rtc8583.pdf

is 0x10 register number mentioned in datasheet? Does it mean that year is stored in user S-RAM and don't describe in datasheet?

This revision is now accepted and ready to land.Oct 30 2017, 1:16 PM
yamori813_yahoo.co.jp updated this revision to Diff 34505.Oct 31 2017, 12:04 PM
  • use err value at return
This revision now requires review to proceed.Oct 31 2017, 12:04 PM
Harbormaster completed remote builds in B12329: Diff 34505.Oct 31 2017, 12:04 PM
Closed by commit rS325233: [i2c/clock] add support for EPSON RTC-8583 (authored by mizhka). · Explain WhyOct 31 2017, 12:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
conf/
1 line
dev/
iicbus/
295 lines

Diff 34506

View Options

head/sys/conf/files

Loading...
View Options

head/sys/dev/iicbus/rtc8583.c

Loading...