Page MenuHomeFreeBSD
Differential D12810

Give a DEV_ERROR for options with invalid characters.
ClosedPublic
Actions

Authored by mat on Oct 27 2017, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 9, 8:48 PM
Unknown Object (File)
Sun, Jan 4, 1:25 PM
Unknown Object (File)
Thu, Jan 1, 9:21 AM
Unknown Object (File)
Sun, Dec 28, 7:29 AM
Unknown Object (File)
Dec 11 2025, 11:37 PM
Unknown Object (File)
Dec 1 2025, 2:55 AM
Unknown Object (File)
Nov 30 2025, 1:32 PM
Unknown Object (File)
Nov 27 2025, 11:02 PM
View All Files
Subscribers
bapt

Details

Reviewers
bapt
Group Reviewers
portmgr
Commits
rP453347: Add a check for options names.
Test Plan

Wonder if an exp-run is needed or if I can do it myself as nothing needs to be
built here.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12267
Build 12558: arc lint + arc unit

Event Timeline

mat created this revision.Oct 27 2017, 2:18 PM
Harbormaster completed remote builds in B12262: Diff 34394.Oct 27 2017, 2:18 PM
mat updated this revision to Diff 34395.Oct 27 2017, 2:21 PM

typo.

Harbormaster completed remote builds in B12263: Diff 34395.Oct 27 2017, 2:22 PM
mat updated this revision to Diff 34396.Oct 27 2017, 2:30 PM
  • Try this with a port that does not have options.
mat updated this revision to Diff 34401.Oct 27 2017, 4:13 PM
  • Move to a DEV_WARNING.
Harbormaster completed remote builds in B12267: Diff 34401.Oct 27 2017, 4:13 PM
mat added a comment.Oct 27 2017, 4:32 PM

There are 19 ports that report this.

If I add - it goes down to 15.

mat added inline comments.Oct 30 2017, 3:12 PM
Mk/bsd.port.mk
4668

So, this also only works on 11.0+, and not on 10.3.

mat updated this revision to Diff 34538.Oct 31 2017, 2:06 PM
  • Globs don't work on 10, do it some other way.
Harbormaster completed remote builds in B12331: Diff 34538.Oct 31 2017, 2:06 PM
bapt accepted this revision.Nov 2 2017, 3:09 PM
bapt added a subscriber: bapt.

LGTM

This revision is now accepted and ready to land.Nov 2 2017, 3:09 PM
Closed by commit rP453347: Add a check for options names. (authored by mat). · Explain WhyNov 2 2017, 3:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
14 lines

Diff 34401

View Options

Mk/bsd.port.mk

Loading...