- Update to 2.1.6
- Enable sound via alsa-lib
Approved by: amdmi3 (maintainer) Approved by: bapt (mentor)
ChangeLog: - Point to new leaderboard server
- Make name resolve non-fatal
- Debian patch for gcc-4.4 integrated
Discovered via @amdmi3's wiki page.
Details
Details
- Reviewers
AMDmi3 bapt - Commits
- rP378866: - Update to 2.1.6
poudriere testport logs:
http://slexy.org/view/s21hoJtmMI (8.4R amd64)
http://slexy.org/view/s2Fdl8xbGt (9.3R i386)
http://slexy.org/view/s20TwGpJyA (10.0R amd64)
http://slexy.org/view/s20mWdpM7D (10.1R i386)
BUFSZ_P2 enabled (default) in audio/alsa-plugins causes:
soundenginealsa.cxx: WARNING - buffersz is not a multiple of periodsz
but sound in the game seems to work fine. Tested within %%%|poudriere
jail -s|%%% environment and 11.0-CURRENT kernel.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
It dies with SIGBUS as soon as player falls down from the scene, exits to the menu or touches a savepoint.
Also, alsa support should be kept optional, as it is a non-native sound library, and the sound in the game is too annoying.
Comment Actions
arc diff doesn't like svn mv files.
I cannot reproduce. It works fine either locally or within poudriere jail for 8.4R amd64, 9.3R i386, 10.0R amd64, 10.1R i386. My kernel is from 11.0C (rS278306) with some unrelated patches applied (e.g. lemul). Since the game doesn't run with swrast I did copy nvidia's libGL into jail(s).
However, there's an unrelated one which happens with OU (aka TLS) option enabled in devel/ode. Given the library is linked statically one may not notice until after games/stormbaancoureur is rebuilt. For some reason the crash only happens with ALSA=off.
ODE INTERNAL ERROR 1: assertion "bInitResult" failed in dInitODE() [odeinit.cpp:490]
Also, alsa support should be kept optional, as it is a non-native
sound library, and the sound in the game is too annoying.
OK. To avoid adding NO_SOUND_DESC let's go with SOUND group where only ALSA is present i.e., user selects nothing under "sound support" -> gets "no sound".
Comment Actions
I've just noticed that current version of stormbaancoureur also crashes, so this is not problem of the update. The crash is in plib, I may investigate it later, alsa is not related.
Regarding the update, see inline comments, otherwise looks good to me.
| games/stormbaancoureur/Makefile | ||
|---|---|---|
| 30 | Is the group really needed? I'd just leave ALSA option, probably enabled by default (to follow upstream). | |
| 33–35 | Please add an extra tab after each `=' for better alignment. | |