Differential D12683

pms/freebsd: fix compiler warnings
ClosedPublic
Actions

Authored by rlibby on Oct 16 2017, 6:34 AM.

Details

Reviewers

pfg

Commits

rS324811: pms/freebsd: fix compiler warnings

Summary

A number of unused variable warnings,
a missing prototype warning (actually a dead function),
and a potential use of an uninitialized variable.

This patch is just for the code under sys/dev/pms/freebsd, which I am assuming we are free to patch and maintain.

I also have a set of patches that would fix the rest of the warnings in pms (outside of pms/freebsd) and actually allow enabling warnings for the module. I assume there is an upstream somewhere, but I haven't been able to find it yet.

Test Plan

buildkernel

Additionally I enabled warnings for pms (after applying those other patches) and ensured a clean build.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12063
Build 12370: arc lint + arc unit

Event Timeline

rlibby created this revision.Oct 16 2017, 6:34 AM

Upstream indeed seems to have disappeared but Benno Rice may know better.

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c
2078	Interesting change. The original code seems to have had some chance for undefined values.

This revision is now accepted and ready to land.Oct 17 2017, 5:34 PM

In D12683#263679, @pfg wrote:

Upstream indeed seems to have disappeared but Benno Rice may know better.

Thanks, I'll ping him.

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c
2078	Yes, although it looks like in practice pmcsc being NULL would cause us to page fault in agtiapi_GetCCB. This was the straightforward fix for the uninitialized variable warning, but reading further it looks like the pmcsc is never NULL from the only caller, agtiapi_cam_action. Would you like this to be fixed up further to KASSERT(pmcsc != NULL) at the top and then remove the pmcsc != NULL guard altogether?